-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS#60416 There is one more wrong example in FROM clause of image layering docs #97433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… layering docs Fixed one more mistaken example of how the base image for RHCOS layering is expected to look like.
/retest |
🤖 Tue Aug 12 12:45:22 - Prow CI generated the docs preview: |
@palonsoro: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
@jldohmann, can you tag a QE reviewer for this? |
@HuijingHei is this something you can PTAL for QE ack? thank you 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @palonsoro! This looks good to me from a docs standards perspective, when QE acks this we can merge.
Oh yeah - the PR says 4.12-4.19, but I assume this goes into 4.20 (unpublished) as well, right? |
Yes, also 4.20 (and any future version. I'll fix the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @palonsoro and @HuijingHei! |
/cherrypick enterprise-4.20 |
@jeana-redhat: #97433 failed to apply on top of branch "enterprise-4.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick enterprise-4.20 |
/cherrypick enterprise-4.17 |
/cherrypick enterprise-4.14 |
@jeana-redhat: new pull request created: #97494 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #97495 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #97496 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #97497 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #97498 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #97499 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #97500 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #97501 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@palonsoro looks like everyone except 4.12 is going to cooperate. Are you able to open a manual backport into 4.12? |
Fixed one more mistaken example of how the base image for RHCOS layering is expected to look like.
Version(s):
4.12 and higher up to latest.
Issue:
https://issues.redhat.com/browse/OCPBUGS-60416
Link to docs preview:
https://97433--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/mco-coreos-layering.html
QE review:
Additional information:
Continuation of OCPBUGS-33598, because there was one more example to fix.