-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS#54405 removing invalid parameters from AWS #97449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/retest |
🤖 Tue Aug 12 19:10:59 - Prow CI generated the docs preview: |
0fac6d2
to
798913b
Compare
@bscott-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@yunjiang29 Hi Yunfei, can you PTAL at this docs PR that removes two incorrect parameters and adds a correct parameter to the table? Thank you |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/remove-label merge-review-in-progress
/remove-label merge-review-needed
/cherrypick enterprise-4.12 |
@bscott-rh: #97449 failed to apply on top of branch "enterprise-4.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick enterprise-4.13 |
@bscott-rh: #97449 failed to apply on top of branch "enterprise-4.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.16 |
/cherrypick enterprise-4.17 |
/cherrypick enterprise-4.18 |
/cherrypick enterprise-4.19 |
/cherrypick enterprise-4.20 |
/cherrypick enterprise-4.14 |
@bscott-rh: new pull request created: #97535 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick enterprise-4.14 |
@bscott-rh: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.14 from head openshift-cherrypick-robot:cherry-pick-97449-to-enterprise-4.14: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-97449-to-enterprise-4.14."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick enterprise-4.15 |
@bscott-rh: new pull request created: #97541 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bscott-rh: new pull request created: #97542 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bscott-rh: new pull request created: #97543 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bscott-rh: new pull request created: #97544 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bscott-rh: new pull request created: #97546 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bscott-rh: new pull request created: #97547 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.12+
Issue:
https://issues.redhat.com/browse/OCPBUGS-54405
Link to docs preview:
https://97449--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_aws/installation-config-parameters-aws#installation-configuration-parameters-optional-aws_installation-config-parameters-aws
QE review:
Removing the
compute.platform.aws.region
andcontrolPlane.platform.aws.region
parameters and replacing them with theplatform.aws.region
parameter.Verified with the latest
openshift-install
binary that the first two parameters do not exist.