Skip to content

OCPBUGS-6952: Closing out PR started by Subhashini #97458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Aug 12, 2025

Version(s): 4.12+
NOTE: Will likely require manual cherrypicks, so I can complete merging myself after merge review. Please just ping me or leave a comment or remove the label to lmk this is ready.

Issue:
https://issues.redhat.com/browse/OCPBUGS-6952

Link to docs preview:
https://97458--ocpdocs-pr.netlify.app/openshift-dedicated/latest/nodes/clusters/nodes-cluster-resource-configure.html#nodes-cluster-resource-configure-jdk_nodes-cluster-resource-configure

QE review:
All SME reviews were completed under #68617

Additional information:
Picking up this bug to complete it since Subhashini has left RH. The content of the PR has already been signed off by stakeholders, and I have updated it to address the comments from @jeana-redhat

@abrennan89 abrennan89 added this to the Continuous Release milestone Aug 12, 2025
@openshift-ci-robot
Copy link

@abrennan89: No Jira issue with key OCPBUG-6952 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 4.12+
NOTE: Will likely require manual cherrypicks, so I can complete merging myself after merge review.

Issue:
https://issues.redhat.com/browse/OCPBUGS-6952

Link to docs preview:

QE review:
All SME reviews were completed under #68617

Additional information:
Picking up this bug to complete it since Subhashini has left RH. The content of the PR has already been signed off by stakeholders, and I have updated it to address the comments from @jeana-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@abrennan89: No Jira issue with key OCPBUG-6952 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 4.12+
NOTE: Will likely require manual cherrypicks, so I can complete merging myself after merge review. Please just ping me or leave a comment or remove the label to lmk this is ready.

Issue:
https://issues.redhat.com/browse/OCPBUGS-6952

Link to docs preview:

QE review:
All SME reviews were completed under #68617

Additional information:
Picking up this bug to complete it since Subhashini has left RH. The content of the PR has already been signed off by stakeholders, and I have updated it to address the comments from @jeana-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Aug 12, 2025

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@abrennan89: No Jira issue with key OCPBUG-6952 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 4.12+
NOTE: Will likely require manual cherrypicks, so I can complete merging myself after merge review. Please just ping me or leave a comment or remove the label to lmk this is ready.

Issue:
https://issues.redhat.com/browse/OCPBUGS-6952

Link to docs preview:
https://97458--ocpdocs-pr.netlify.app/openshift-dedicated/latest/nodes/clusters/nodes-cluster-resource-configure.html#nodes-cluster-resource-configure-jdk_nodes-cluster-resource-configure

QE review:
All SME reviews were completed under #68617

Additional information:
Picking up this bug to complete it since Subhashini has left RH. The content of the PR has already been signed off by stakeholders, and I have updated it to address the comments from @jeana-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 12, 2025
@lpettyjo lpettyjo added merge-review-in-progress Signifies that the merge review team is reviewing this PR ok-to-merge and removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Aug 13, 2025
@lpettyjo lpettyjo merged commit a95d5d6 into openshift:main Aug 13, 2025
2 checks passed
@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.20

@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #97487

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.18

@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #97488

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #97489

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.16

@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@lpettyjo: #97458 failed to apply on top of branch "enterprise-4.16":

Applying: OCPBUG-6952: Closing out PR started by Subhashini
Using index info to reconstruct a base tree...
M	modules/nodes-cluster-resource-configure-jdk.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nodes-cluster-resource-configure-jdk.adoc
CONFLICT (content): Merge conflict in modules/nodes-cluster-resource-configure-jdk.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUG-6952: Closing out PR started by Subhashini

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lpettyjo: #97458 failed to apply on top of branch "enterprise-4.15":

Applying: OCPBUG-6952: Closing out PR started by Subhashini
Using index info to reconstruct a base tree...
M	modules/nodes-cluster-resource-configure-jdk.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nodes-cluster-resource-configure-jdk.adoc
CONFLICT (content): Merge conflict in modules/nodes-cluster-resource-configure-jdk.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUG-6952: Closing out PR started by Subhashini

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #97491

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

@abrennan89: Jira Issue OCPBUGS-6952 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Version(s): 4.12+
NOTE: Will likely require manual cherrypicks, so I can complete merging myself after merge review. Please just ping me or leave a comment or remove the label to lmk this is ready.

Issue:
https://issues.redhat.com/browse/OCPBUGS-6952

Link to docs preview:
https://97458--ocpdocs-pr.netlify.app/openshift-dedicated/latest/nodes/clusters/nodes-cluster-resource-configure.html#nodes-cluster-resource-configure-jdk_nodes-cluster-resource-configure

QE review:
All SME reviews were completed under #68617

Additional information:
Picking up this bug to complete it since Subhashini has left RH. The content of the PR has already been signed off by stakeholders, and I have updated it to address the comments from @jeana-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants