Skip to content

OCPMCP-9: add acm cluster provider #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 30, 2025
Merged

OCPMCP-9: add acm cluster provider #58

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9c04e31
feat: add acm cluster provider
Cali0707 Oct 15, 2025
17c0ab9
refactor(config): introduce provider-specific config registry
Cali0707 Oct 15, 2025
7366d81
refactor: use provider config registry for acm provider
Cali0707 Oct 15, 2025
85ba743
fix merge conflicts
Cali0707 Oct 27, 2025
ef063b6
fix: acm provider works with new provider/manager design
Cali0707 Oct 27, 2025
1bccb73
cleanup: move provider constants to provider specific file
Cali0707 Oct 27, 2025
a0b63e5
Merge remote-tracking branch 'downstream/main' into acm-cluster-provider
Cali0707 Oct 30, 2025
e3658c0
feat: resolve ca file paths
Cali0707 Oct 30, 2025
613ca77
fix: typo
Cali0707 Oct 30, 2025
a7cac28
fix: use cluster manager for VerifyToken
Cali0707 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pkg/kubernetes/provider_acm_hub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,11 @@ func (p *acmHubClusterProvider) IsOpenShift(ctx context.Context) bool {
}

func (p *acmHubClusterProvider) VerifyToken(ctx context.Context, target, token, audience string) (*authenticationv1api.UserInfo, []string, error) {
// use hub cluster for token verification regardless of target
// TODO(Cali0707): update this to work off the configured auth provider for the target
return p.hubManager.VerifyToken(ctx, token, audience)
manager, err := p.managerForCluster(target)
if err != nil {
return nil, nil, fmt.Errorf("failed to get manager for cluster '%s', unable to verify token", target)
}
return manager.VerifyToken(ctx, token, audience)
Comment on lines +229 to +233
Copy link
Member

@matzew matzew Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now verifies tokens against the correct target cluster (should)

}

func (p *acmHubClusterProvider) GetDerivedKubernetes(ctx context.Context, target string) (*Kubernetes, error) {
Expand Down