NO-JIRA: Sync downstream #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…antiations (containers#379) * refactor(kubernetes): Provider implementations deal with Manager instantiations Removed `*Manager` parameter from `ProviderFactory`. Provider implementations should deal with the appropriate (base) Manager instantiation if needed at all. Manager creation function divided into two explicit functions: - NewKubeconfigManager: to be used when using KubeConfig files - NewInClusterManager: to be used inside a cluster New functions contain validations to ensure they are used in the expected places. This ensures that the right manager is used by the provider implementation. Fake kubeconfig for in-cluster Manager is now generated when the Manager is created. This kubeconfig has the "magic" strings (inClusterKubeConfigDefaultContext) that are used by the MCP server and tool mutators. Signed-off-by: Marc Nuri <[email protected]> * review: Provider implementation refactor Signed-off-by: Marc Nuri <[email protected]> --------- Signed-off-by: Marc Nuri <[email protected]>
…ontainers#383) Signed-off-by: Calum Murray <[email protected]>
…ontainers#388) Bumps [github.com/mark3labs/mcp-go](https://github.com/mark3labs/mcp-go) from 0.41.1 to 0.42.0. - [Release notes](https://github.com/mark3labs/mcp-go/releases) - [Commits](mark3labs/mcp-go@v0.41.1...v0.42.0) --- updated-dependencies: - dependency-name: github.com/mark3labs/mcp-go dependency-version: 0.42.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…for OIDC (containers#354) * Initial KinD setup Signed-off-by: Matthias Wessendorf <[email protected]> * Initial Keycloak container setup Signed-off-by: Matthias Wessendorf <[email protected]> * Adding an initial realm setup Signed-off-by: Matthias Wessendorf <[email protected]> * Adding OIDC issuer and realm updates, adding cert-manager and handling self-signed certificates Signed-off-by: Matthias Wessendorf <[email protected]> * Updates to script b/c of invalid auth config Signed-off-by: Matthias Wessendorf <[email protected]> * Adjusting ports and better support for mac/podman Signed-off-by: Matthias Wessendorf <[email protected]> * Addressing review comments: * do not expose all internal tasks, just keep the important targets documents * remove the keycloak-forward * move binaries for dev tools to _output * generate a configuration TOML file into the _output folder Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
* feat(http): add custom CA certificate support for OIDC providers add support for nodes logs Signed-off-by: blublinsky <[email protected]> * removed some tools Signed-off-by: blublinsky <[email protected]> --------- Signed-off-by: blublinsky <[email protected]> Co-authored-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
…#397) Adds a softlink to AGENTS.md so that CLAUDE can reuse the information. Signed-off-by: Marc Nuri <[email protected]>
… overrides (containers#396) * feat(config): default configuration with merge support for downstream overrides Creates the required infrastructure for downstream forks to be able to provide default config overrides without modifying the original source code. Downstream forks should be able to create merge/rebase scripts that automatically accepted downstream merge conflicts in config_default_overrides.go since this file will never change upstream. Example usage for downstream forks: To customize defaults, simply populate fields in the returned StaticConfig: ```go func defaultOverrides() *StaticConfig { return &StaticConfig{ ListOutput: "json", // Override default list output format Toolsets: []string{"core"}, // Override default enabled toolsets Port: "9000", // Override default port } } ``` Any fields specified here will override the base defaults defined in config_default.go. Fields not specified will preserve their base default values. Signed-off-by: Marc Nuri <[email protected]> * test: skip downstream toolset (full) tests Skips toolset metadata tests in case there are config overrides. This is useful in downstream forks where the default toolsets might be different to those upstream. Signed-off-by: Marc Nuri <[email protected]> --------- Signed-off-by: Marc Nuri <[email protected]>
…ability (containers#401) Signed-off-by: Marc Nuri <[email protected]>
* fix(nodes): reviewed kubernetes.nodes implementation - Changed node_log tool name to nodes_log for consistency - Added access control check for nodes and configured denied resources - Migrated tests to testify - Added complete test coverage for nodes_log https://kubernetes.io/docs/concepts/cluster-administration/system-logs/#log-query Signed-off-by: Marc Nuri <[email protected]> * test(nodes): add test for nodes_log tool with negative tail argument Signed-off-by: Marc Nuri <[email protected]> --------- Signed-off-by: Marc Nuri <[email protected]>
…ity (containers#400) * test(pods): update PodsExec tests to use testify and improve readability Signed-off-by: Marc Nuri <[email protected]> * review: enhance namespace="" test description for pods_exec clarity Signed-off-by: Marc Nuri <[email protected]> --------- Signed-off-by: Marc Nuri <[email protected]>
…ty (containers#402) Signed-off-by: Marc Nuri <[email protected]>
…ntainers#393) Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Marc Nuri <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@Cali0707: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Cali0707: GitHub didn't allow me to request PR reviews from the following users: manusa. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. |
|
@Cali0707: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, Cali0707, harche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should bring the remainder of the provider/manager interface changes that we added upstream and unblock #58 and #51