Skip to content

Conversation

@matzew
Copy link
Member

@matzew matzew commented Nov 3, 2025

Adding setup scripts for Hub cluster creation and importing new managed clusters

@openshift-ci openshift-ci bot requested review from Cali0707 and ardaguclu November 3, 2025 11:05
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@matzew
Copy link
Member Author

matzew commented Nov 3, 2025

/assign @Cali0707 this can be tested with "dev cluster" and maybe cluster-bot

@matzew
Copy link
Member Author

matzew commented Nov 3, 2025

/retitle: OCPMCP-29: Adding ACM setup script

@openshift-ci openshift-ci bot changed the title feat(acm): Adding ACM setup script : OCPMCP-29: Adding ACM setup script Nov 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 3, 2025

@matzew: This pull request references OCPMCP-29 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Adding setup scripts for Hub cluster creation and importing new managed clusters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@matzew
Copy link
Member Author

matzew commented Nov 3, 2025

/retitle OCPMCP-29: Adding ACM setup script

@openshift-ci openshift-ci bot changed the title : OCPMCP-29: Adding ACM setup script OCPMCP-29: Adding ACM setup script Nov 3, 2025
Copy link

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew can you add some kind of OPENSHIFT_DEVELOPMENT.md (so we don't conflict with any upstream DEVELOPMENT.md) that explains how to use these targets? In particular, the different env vars needed

matzew and others added 6 commits November 4, 2025 10:13
@matzew
Copy link
Member Author

matzew commented Nov 4, 2025

/test images

@matzew
Copy link
Member Author

matzew commented Nov 4, 2025

can you add some kind of OPENSHIFT_DEVELOPMENT.md

@Cali0707 Absolutely! That is exactly the plan, once I have all the bits together.

I did these initial ACM related install scripts first to get some smaller, narrowed focus going.

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2025

@matzew: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants