-
Notifications
You must be signed in to change notification settings - Fork 12
OCPMCP-29: Adding ACM setup script #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @Cali0707 this can be tested with "dev cluster" and maybe cluster-bot |
|
/retitle: OCPMCP-29: Adding ACM setup script |
|
@matzew: This pull request references OCPMCP-29 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle OCPMCP-29: Adding ACM setup script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matzew can you add some kind of OPENSHIFT_DEVELOPMENT.md (so we don't conflict with any upstream DEVELOPMENT.md) that explains how to use these targets? In particular, the different env vars needed
…g new managed clusters Signed-off-by: Matthias Wessendorf <[email protected]>
Co-authored-by: Dale Haiducek <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
|
/test images |
@Cali0707 Absolutely! That is exactly the plan, once I have all the bits together. I did these initial ACM related install scripts first to get some smaller, narrowed focus going. |
|
@matzew: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Adding setup scripts for Hub cluster creation and importing new managed clusters