[release-4.18] OCPBUGS-52173: unset PAXRecords and Xattrs in image layers when applying to disk

[joelanford]

Manual cherry pick of openshift/operator-framework-operator-controller#280

Note that the original bug (https://issues.redhat.com/browse/OCPBUGS-52161) was about bundle images, which are purely in the domain of operator-controller (not catalogd). However, 4.19 has an image unpacking library that is shared between operator-controller and catalogd, so when we fixed this issue for bundle images in 4.19, we also fixed it for catalog images.

Since we are backporting the 4.19 fix to 4.18, it is necessary to change catalogd's 4.18 image unpacking implementation to ensure that the 4.19 fix is actually fully applied in 4.18.

[openshift-ci-robot]

@joelanford: This pull request references Jira Issue OCPBUGS-52173, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-52161 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-52161 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry pick of openshift/operator-framework-operator-controller#280

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@joelanford: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[camilamacedo86]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joelanford]

/label backport-risk-assessed

[jianzhangbjz]

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-52173
/label qe-approved
/label cherry-pick-approved

[openshift-ci-robot]

@joelanford: Jira Issue OCPBUGS-52173: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/operator-framework-operator-controller#281 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-52173 has not been moved to the MODIFIED state.

In response to this:

Manual cherry pick of openshift/operator-framework-operator-controller#280

Note that the original bug (https://issues.redhat.com/browse/OCPBUGS-52161) was about bundle images, which are purely in the domain of operator-controller (not catalogd). However, 4.19 has an image unpacking library that is shared between operator-controller and catalogd, so when we fixed this issue for bundle images in 4.19, we also fixed it for catalog images.

Since we are backporting the 4.19 fix to 4.18, it is necessary to change catalogd's 4.18 image unpacking implementation to ensure that the 4.19 fix is actually fully applied in 4.18.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-catalogd
This PR has been included in build ose-olm-catalogd-container-v4.18.0-202503030837.p0.gfa0280c.assembly.stream.el9.
All builds following this will include this PR.