-
Notifications
You must be signed in to change notification settings - Fork 73
NO-ISSUE: Update verify_commits.sh to use main branch #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Todd Short <[email protected]>
@tmshort: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The error being seen:
|
Looks like not, because if I do that I get an error, whereas 108 saying 'master' appears to grab the correct list of commits to evaluate. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
And verify-deps is failing? This has nothing to do with that‽‽ |
This looks like a change in openshift/api dependency checking, and some "contagious" version. Great that it is "discovered" instead of "advertised". |
Fixed here and needing to come downstream to resolve this, I guess. Additional conversation which was discovered only after another team encountered the new "antibiotics": https://redhat-internal.slack.com/archives/C07RDCVEYJG/p1760624199090789 |
/override ci/prow/verify-deps |
@jupierce: Overrode contexts on behalf of jupierce: ci/prow/verify-deps In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest-required |
/retest |
/retest-required |
@tmshort: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We now use the main branch. The CI call to this was changed to use
main
, but we might as well make it the default sincemake verify
can be run locally.