Skip to content

NO-ISSUE: Update verify_commits.sh to use main branch #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-ISSUE: Update verify_commits.sh to use main branch #1127

wants to merge 1 commit into from

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Oct 17, 2025 •
edited
Loading

We now use the main branch. The CI call to this was changed to use main, but we might as well make it the default since make verify can be run locally.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2025
@openshift-ci-robot
Copy link

@tmshort: This pull request explicitly references no jira issue.

In response to this:

We now use the main branch. The call to this was changed to use main, but we might as well make it the default since make verify can be run locally.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor Author

tmshort commented Oct 17, 2025

The error being seen:

/Library/Developer/CommandLineTools/usr/bin/make verify-commits
./scripts/verify_commits.sh  # see https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables
fatal: bad revision '^master'
[2025-10-17T12:18:05-0400]: detected 0 commit(s) to verify
Successfully validated all commits

@grokspawn
Copy link
Contributor

grokspawn commented Oct 17, 2025 •
edited
Loading

Also update 108?

Looks like not, because if I do that I get an error, whereas 108 saying 'master' appears to grab the correct list of commits to evaluate.

@openshift-ci openshift-ci bot requested review from bentito and perdasilva October 17, 2025 16:19
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Oct 17, 2025

And verify-deps is failing? This has nothing to do with that‽‽

@grokspawn
Copy link
Contributor

This looks like a change in openshift/api dependency checking, and some "contagious" version. Great that it is "discovered" instead of "advertised".

@grokspawn
Copy link
Contributor

grokspawn commented Oct 17, 2025 •
edited
Loading

Fixed here and needing to come downstream to resolve this, I guess.

Additional conversation which was discovered only after another team encountered the new "antibiotics": https://redhat-internal.slack.com/archives/C07RDCVEYJG/p1760624199090789

@jupierce
Copy link
Contributor

/override ci/prow/verify-deps

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

@jupierce: Overrode contexts on behalf of jupierce: ci/prow/verify-deps

In response to this:

/override ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@grokspawn
Copy link
Contributor

/retest-required

@tmshort
Copy link
Contributor Author

tmshort commented Oct 18, 2025

/retest

@tmshort
Copy link
Contributor Author

tmshort commented Oct 18, 2025

/retest-required

1 similar comment
@jianzhangbjz
Copy link
Contributor

/retest-required

@jianzhangbjz
Copy link
Contributor

/verified by pass
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 20, 2025
@openshift-ci-robot
Copy link

@jianzhangbjz: This PR has been marked as verified by pass.

In response to this:

/verified by pass
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

@tmshort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn dd29742 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-olm dd29742 link true /test e2e-gcp-olm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bdc0d75 and 2 for PR HEAD dd29742 in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentito bentito Awaiting requested review from bentito

@perdasilva perdasilva Awaiting requested review from perdasilva

Assignees

@jianzhangbjz jianzhangbjz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tmshort @openshift-ci-robot @grokspawn @jupierce @jianzhangbjz