[release-4.18] OCPBUGS-48660: Fix concurrent namespace resolution #946

perdasilva · 2025-01-21T07:40:03Z

This is a manual cherry-pick of #936

…tion handler (#3483) * switch queue informer to use types.NamespacedName; relocate deletion handler Signed-off-by: Joe Lanford <[email protected]> * Add error message to object count assertion failure Signed-off-by: Per Goncalves da Silva <[email protected]> --------- Signed-off-by: Joe Lanford <[email protected]> Signed-off-by: Per Goncalves da Silva <[email protected]> Co-authored-by: Per Goncalves da Silva <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: edb751b9718ffe29e8462ce17867ec3db3b349ff

Signed-off-by: Per Goncalves da Silva <[email protected]>

openshift-ci-robot · 2025-01-21T07:40:10Z

@perdasilva: This pull request references Jira Issue OCPBUGS-48636, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-48486 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-48486 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #936

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-01-21T07:40:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-01-21T08:56:40Z

@perdasilva: This pull request references Jira Issue OCPBUGS-48660, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #936

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2025-01-21T09:06:20Z

/jira refresh

openshift-ci-robot · 2025-01-21T09:06:25Z

@perdasilva: This pull request references Jira Issue OCPBUGS-48660, which is invalid:

expected dependent Jira Issue OCPBUGS-48636 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
expected dependent Jira Issue OCPBUGS-48636 to target a version in 4.19.0, but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2025-01-21T09:07:32Z

/jira refresh

openshift-ci-robot · 2025-01-21T09:07:40Z

@perdasilva: This pull request references Jira Issue OCPBUGS-48660, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-48636 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-48636 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2025-01-21T09:31:18Z

/retest

openshift-ci · 2025-01-21T11:18:59Z

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

kuiwang02 · 2025-01-21T12:23:15Z

/label cherry-pick-approved
/label qe-approved

openshift-ci-robot · 2025-01-21T12:24:12Z

@perdasilva: This pull request references Jira Issue OCPBUGS-48660, which is invalid:

expected dependent Jira Issue OCPBUGS-48636 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead
expected dependent Jira Issue OCPBUGS-48636 to target a version in 4.19.0, but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is a manual cherry-pick of #936

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2025-01-21T12:29:12Z

/label backport-risk-assessed

camilamacedo86 · 2025-01-21T12:40:47Z

/lgtm

perdasilva · 2025-01-21T13:13:15Z

/jira refresh

openshift-ci-robot · 2025-01-21T13:13:20Z

@perdasilva: This pull request references Jira Issue OCPBUGS-48660, which is invalid:

expected dependent Jira Issue OCPBUGS-48636 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2025-01-21T13:14:17Z

/jira refresh

openshift-ci-robot · 2025-01-21T13:14:24Z

@perdasilva: This pull request references Jira Issue OCPBUGS-48660, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-48636 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-48636 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-01-21T13:19:39Z

@perdasilva: Jira Issue OCPBUGS-48660: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#946

Jira Issue OCPBUGS-48660 has been moved to the MODIFIED state.

In response to this:

This is a manual cherry-pick of #936

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-01-21T14:44:52Z

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.18.0-202501211403.p0.g33f0519.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2025-01-21T14:44:52Z

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.18.0-202501211403.p0.g33f0519.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2025-01-21T14:50:52Z

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.18.0-202501211403.p0.g33f0519.assembly.stream.el9.
All builds following this will include this PR.

joelanford and others added 3 commits January 20, 2025 19:28

[CARRY] fixup ns labeler plugin

1d7eee7

Signed-off-by: Per Goncalves da Silva <[email protected]>

[CARRY] address lint issues in namespace labeler plugin

cf773f6

Signed-off-by: Per Goncalves da Silva <[email protected]>

openshift-ci bot assigned perdasilva Jan 21, 2025

openshift-ci bot requested review from ankitathomas, joelanford and kuiwang02 January 21, 2025 07:40

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025

perdasilva mentioned this pull request Jan 21, 2025

[release-4.17] OCPBUGS-45845: Fix concurrent namespace resolution #944

Merged

perdasilva changed the title ~~[release-4.18] OCPBUGS-48636: Fix concurrent namespace resolution~~ [release-4.18] OCPBUGS-48660: Fix concurrent namespace resolution Jan 21, 2025

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 21, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 21, 2025

openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Jan 21, 2025

openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 21, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 21, 2025

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 21, 2025

openshift-ci bot assigned bandrade, emmajiafan, jianzhangbjz, KeenonLee, kuiwang02 and Xia-Zhao-rh Jan 21, 2025

openshift-ci bot assigned camilamacedo86 Jan 21, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 21, 2025

openshift-merge-bot bot merged commit 33f0519 into openshift:release-4.18 Jan 21, 2025
14 checks passed

[release-4.18] OCPBUGS-48660: Fix concurrent namespace resolution #946

[release-4.18] OCPBUGS-48660: Fix concurrent namespace resolution #946

Uh oh!

Conversation

perdasilva commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

openshift-ci bot commented Jan 21, 2025

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

perdasilva commented Jan 21, 2025

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

perdasilva commented Jan 21, 2025

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

perdasilva commented Jan 21, 2025

Uh oh!

openshift-ci bot commented Jan 21, 2025

Uh oh!

kuiwang02 commented Jan 21, 2025

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

perdasilva commented Jan 21, 2025

Uh oh!

camilamacedo86 commented Jan 21, 2025

Uh oh!

perdasilva commented Jan 21, 2025

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

perdasilva commented Jan 21, 2025

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

openshift-bot commented Jan 21, 2025

Uh oh!

openshift-bot commented Jan 21, 2025

Uh oh!

openshift-bot commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

perdasilva commented Jan 21, 2025 •

edited

Loading