Skip to content

Conversation

jianzhangbjz
Copy link
Contributor

It seems that #457 doesn’t work as expected based on #467 (comment). Therefore, I’ve created a new PR to add the QE leader to the downstream approvers.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 16, 2025
@openshift-ci-robot
Copy link

@jianzhangbjz: This pull request explicitly references no jira issue.

In response to this:

It seems that #457 doesn’t work as expected based on #467 (comment). Therefore, I’ve created a new PR to add the QE leader to the downstream approvers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianzhangbjz
Copy link
Contributor Author

Hi @tmshort @perdasilva , could you help approve it when you get a chance? Thanks!

@jianzhangbjz
Copy link
Contributor Author

/test e2e-aws-techpreview-olmv1-ext

@jianzhangbjz
Copy link
Contributor Author

/retest-required

@jianzhangbjz
Copy link
Contributor Author

/verified by pass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 16, 2025
@openshift-ci-robot
Copy link

@jianzhangbjz: This PR has been marked as verified by pass.

In response to this:

/verified by pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor

tmshort commented Sep 16, 2025

/verify-owners

@tmshort
Copy link
Contributor

tmshort commented Sep 16, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2025
@tmshort
Copy link
Contributor

tmshort commented Sep 16, 2025

/test e2e-aws-techpreview-olmv1-ext
/test okd-scos-e2e-aws-ovn

@tmshort
Copy link
Contributor

tmshort commented Sep 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2025
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

@jianzhangbjz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit db481dd into openshift:main Sep 16, 2025
10 checks passed
@jianzhangbjz jianzhangbjz deleted the downstream branch September 17, 2025 00:28
@jianzhangbjz
Copy link
Contributor Author

/cherry-pick release-4.20

@jianzhangbjz
Copy link
Contributor Author

/cherry-pick release-4.19

@jianzhangbjz
Copy link
Contributor Author

/cherry-pick release-4.18

@jianzhangbjz
Copy link
Contributor Author

/cherry-pick release-4.17

@openshift-cherrypick-robot

@jianzhangbjz: new pull request created: #513

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jianzhangbjz: #477 failed to apply on top of branch "release-4.19":

Applying: UPSTREAM: <carry>: add jiazha to approvers
Using index info to reconstruct a base tree...
M	DOWNSTREAM_OWNERS_ALIASES
Falling back to patching base and 3-way merge...
Auto-merging DOWNSTREAM_OWNERS_ALIASES
CONFLICT (content): Merge conflict in DOWNSTREAM_OWNERS_ALIASES
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 UPSTREAM: <carry>: add jiazha to approvers

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jianzhangbjz: #477 failed to apply on top of branch "release-4.18":

Applying: UPSTREAM: <carry>: add jiazha to approvers
Using index info to reconstruct a base tree...
M	DOWNSTREAM_OWNERS_ALIASES
Falling back to patching base and 3-way merge...
Auto-merging DOWNSTREAM_OWNERS_ALIASES
CONFLICT (content): Merge conflict in DOWNSTREAM_OWNERS_ALIASES
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 UPSTREAM: <carry>: add jiazha to approvers

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jianzhangbjz: #477 failed to apply on top of branch "release-4.17":

Applying: UPSTREAM: <carry>: add jiazha to approvers
Using index info to reconstruct a base tree...
M	DOWNSTREAM_OWNERS_ALIASES
Falling back to patching base and 3-way merge...
Auto-merging DOWNSTREAM_OWNERS_ALIASES
CONFLICT (content): Merge conflict in DOWNSTREAM_OWNERS_ALIASES
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 UPSTREAM: <carry>: add jiazha to approvers

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants