Skip to content

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Oct 7, 2025

I recently moved the webhook-operator repository to the operator-framework GitHub org. This PR updates the webhook OTE tests to use the image built from that repo.

@openshift-ci-robot
Copy link

@perdasilva: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2025
@perdasilva
Copy link
Contributor Author

/hold using this to test the new images

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2025
@openshift-ci openshift-ci bot requested review from thetechnick and trgeiger October 7, 2025 07:54
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@perdasilva perdasilva force-pushed the webhook-controller-image-update branch from 8b27c66 to a98e3fe Compare October 7, 2025 13:18
@tmshort
Copy link
Contributor

tmshort commented Oct 7, 2025

/hold
The commit headline is wrong - ci/prow/verify-commits is failing.
(I know this is an extra hold, but we've been bitten by bad commit headlines in the recent past)

@tmshort
Copy link
Contributor

tmshort commented Oct 7, 2025

This should really have a ticket associated with it (and not NO-ISSUE)

@perdasilva perdasilva force-pushed the webhook-controller-image-update branch from a98e3fe to 413d9c5 Compare October 7, 2025 14:35
@perdasilva perdasilva changed the title NO-ISSUE: Update webhook ote tests to use latest webhook-operator OPRUN-4184: Update webhook ote tests to use latest webhook-operator Oct 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2025

@perdasilva: This pull request references OPRUN-4184 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2025

@perdasilva: This pull request references OPRUN-4184 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@tmshort
Copy link
Contributor

tmshort commented Oct 7, 2025

/hold
Why all the whitespace changes? Did you change all the TABs to SPACEs?
make lint in openshift/tests-extension` fails:

tshort@cube:~/.../openshift/tests-extension (PR-500)$ make lint
/home/tshort/go/bin/golangci-lint-v2.1.6 run
openshift/tests-extension/test/webhooks.go:4:1  gci  File is not properly formatted
1 issues:
* gci: 1
make: *** [Makefile:61: lint] Error 1
tshort@cube:~/.../openshift/tests-extension (PR-500)$

Yup, you need to run go fmt.

@perdasilva perdasilva force-pushed the webhook-controller-image-update branch from 413d9c5 to 2b1be4f Compare October 7, 2025 15:03
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

New changes are detected. LGTM label has been removed.

@perdasilva
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2025
@bandrade
Copy link

bandrade commented Oct 7, 2025

/label qe-approved
/verified by @bandrade

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 7, 2025
@openshift-ci-robot
Copy link

@bandrade: This PR has been marked as verified by @bandrade.

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2025

@perdasilva: This pull request references OPRUN-4184 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor

tmshort commented Oct 7, 2025

/lgtm

@tmshort
Copy link
Contributor

tmshort commented Oct 7, 2025

The e2e-aws-techpreview-olmv1-ext tests failed, and I suspect the openshift-e2e-aws-* tests will fail as well

@tmshort
Copy link
Contributor

tmshort commented Oct 7, 2025

/retest-required

@camilamacedo86
Copy link
Contributor

@perdasilva perdasilva force-pushed the webhook-controller-image-update branch from 2b1be4f to fc42897 Compare October 8, 2025 16:01
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Oct 8, 2025
@tmshort
Copy link
Contributor

tmshort commented Oct 8, 2025

The force-push didn't include any additional changes.

@tmshort
Copy link
Contributor

tmshort commented Oct 8, 2025

/test openshift-e2e-aws-techpreview

@jianzhangbjz
Copy link
Contributor

/assign @bandrade

@tmshort
Copy link
Contributor

tmshort commented Oct 9, 2025

/test openshift-e2e-aws-techpreview

@kuiwang02
Copy link
Contributor

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6 openshift/origin#30353

Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/39d9f5e0-a4ca-11f0-8d66-3286ae764496-0

@kuiwang02
Copy link
Contributor

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6-techpreview openshift/origin#30353

Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c9217010-a4d0-11f0-97fc-2de4ad9d441e-0

@kuiwang02
Copy link
Contributor

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview openshift/origin#30353

Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2580bf00-a4d1-11f0-8f9e-aea2aba3f2bf-0

@jianzhangbjz
Copy link
Contributor

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6 openshift/origin#30356

Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

@jianzhangbjz: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@perdasilva
Copy link
Contributor Author

@jianzhangbjz this PR just doesn't flip the tests to run on d/c. I was just updating the image to be the same one that we added to the origin mirror set to make sure it worked (before we updated origin). We still need to modify the webhook tests to build the catalog and bundle images like we do in the incompatible test. If this PR is passing, we can merge it.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025

@perdasilva: This pull request references OPRUN-4184 which is a valid jira issue.

In response to this:

I recently moved the webhook-operator repository to the operator-framework GitHub org. This PR updates the webhook OTE tests to use the image built from that repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor

tmshort commented Oct 10, 2025

/test openshift-e2e-aws-techpreview

Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

@perdasilva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn fc42897 link false /test okd-scos-e2e-aws-ovn
ci/prow/openshift-e2e-aws-techpreview fc42897 link false /test openshift-e2e-aws-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants