-
Notifications
You must be signed in to change notification settings - Fork 31
OPRUN-4184: Update webhook ote tests to use latest webhook-operator #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OPRUN-4184: Update webhook ote tests to use latest webhook-operator #500
Conversation
@perdasilva: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold using this to test the new images |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8b27c66
to
a98e3fe
Compare
/hold |
This should really have a ticket associated with it (and not NO-ISSUE) |
a98e3fe
to
413d9c5
Compare
@perdasilva: This pull request references OPRUN-4184 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@perdasilva: This pull request references OPRUN-4184 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold
Yup, you need to run |
413d9c5
to
2b1be4f
Compare
New changes are detected. LGTM label has been removed. |
/unhold |
/label qe-approved |
@bandrade: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@perdasilva: This pull request references OPRUN-4184 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
The |
/retest-required |
…rator Signed-off-by: Per Goncalves da Silva <[email protected]>
2b1be4f
to
fc42897
Compare
The force-push didn't include any additional changes. |
/test openshift-e2e-aws-techpreview |
/assign @bandrade |
/test openshift-e2e-aws-techpreview |
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6 openshift/origin#30353 |
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/39d9f5e0-a4ca-11f0-8d66-3286ae764496-0 |
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6-techpreview openshift/origin#30353 |
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c9217010-a4d0-11f0-97fc-2de4ad9d441e-0 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview openshift/origin#30353 |
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2580bf00-a4d1-11f0-8f9e-aea2aba3f2bf-0 |
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6 openshift/origin#30356 |
@jianzhangbjz: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
@jianzhangbjz this PR just doesn't flip the tests to run on d/c. I was just updating the image to be the same one that we added to the origin mirror set to make sure it worked (before we updated origin). We still need to modify the webhook tests to build the catalog and bundle images like we do in the incompatible test. If this PR is passing, we can merge it. |
@perdasilva: This pull request references OPRUN-4184 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test openshift-e2e-aws-techpreview |
@perdasilva: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I recently moved the webhook-operator repository to the operator-framework GitHub org. This PR updates the webhook OTE tests to use the image built from that repo.