Skip to content

OPRUN-4199: [Default Catalog Tests] - Change logic to get ocp images from openshift/catalogd/manifests.yaml #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

OPRUN-4199: [Default Catalog Tests] - Change logic to get ocp images from openshift/catalogd/manifests.yaml #521

merged 1 commit into from
Oct 14, 2025

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 13, 2025 •
edited
Loading

Test locally:

$ make test-catalog
go build -mod=vendor -o /Users/camilam/go/src/github/operator-framework-operator-controller/openshift/default-catalog-consistency/bin/ginkgo ./vendor/github.com/onsi/ginkgo/v2/ginkgo
/Users/camilam/go/src/github/operator-framework-operator-controller/openshift/default-catalog-consistency/bin/ginkgo  \
		--junit-report=junit_olm.xml ./test/validate/...
2025/10/13 18:56:59 maxprocs: Leaving GOMAXPROCS=11: CPU quota undefined
Running Suite: OLM-Catalog-Validation - /Users/camilam/go/src/github/operator-framework-operator-controller/openshift/default-catalog-consistency/test/validate
===============================================================================================================================================================
Random Seed: 1760378219

Will run 8 of 8 specs
••••no default policy found for (registry.redhat.io/redhat/certified-operator-index:v4.20), using insecure policy

@openshift-ci openshift-ci bot requested review from oceanc80 and pedjak October 13, 2025 17:49
@camilamacedo86
UPSTREAM: <carry>: [Default Catalog Tests] - Change logic to get ocp …
139ba75 
…images from openshift/catalogd/manifests.yaml
@camilamacedo86 camilamacedo86 changed the title [Default Catalog Tests] - Change logic to get ocp images from openshift/catalogd/manifests.yaml NO-ISSUE: [Default Catalog Tests] - Change logic to get ocp images from openshift/catalogd/manifests.yaml Oct 13, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 13, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title NO-ISSUE: [Default Catalog Tests] - Change logic to get ocp images from openshift/catalogd/manifests.yaml OPRUN-4199: [Default Catalog Tests] - Change logic to get ocp images from openshift/catalogd/manifests.yaml Oct 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2025 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-4199 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor

tmshort commented Oct 13, 2025

/hold for #519

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2025 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-4199 which is a valid jira issue.

In response to this:

Test locally:

$ make test-catalog
go build -mod=vendor -o /Users/camilam/go/src/github/operator-framework-operator-controller/openshift/default-catalog-consistency/bin/ginkgo ./vendor/github.com/onsi/ginkgo/v2/ginkgo
/Users/camilam/go/src/github/operator-framework-operator-controller/openshift/default-catalog-consistency/bin/ginkgo  \
  	--junit-report=junit_olm.xml ./test/validate/...
2025/10/13 18:56:59 maxprocs: Leaving GOMAXPROCS=11: CPU quota undefined
Running Suite: OLM-Catalog-Validation - /Users/camilam/go/src/github/operator-framework-operator-controller/openshift/default-catalog-consistency/test/validate
===============================================================================================================================================================
Random Seed: 1760378219

Will run 8 of 8 specs
••••no default policy found for (registry.redhat.io/redhat/certified-operator-index:v4.20), using insecure policy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tmshort
tmshort reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@tmshort
Copy link
Contributor

tmshort commented Oct 13, 2025

/unhold
#519 merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 13, 2025
Merged
@jianzhangbjz
Copy link
Contributor

/verified by pass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 14, 2025
@openshift-ci-robot
Copy link

@jianzhangbjz: This PR has been marked as verified by pass.

In response to this:

/verified by pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1f66d6f into openshift:main Oct 14, 2025
12 checks passed
@camilamacedo86 camilamacedo86 deleted the change-location branch October 14, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oceanc80 oceanc80 Awaiting requested review from oceanc80

@pedjak pedjak Awaiting requested review from pedjak

1 more reviewer

@tmshort tmshort tmshort left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camilamacedo86 @openshift-ci-robot @tmshort @jianzhangbjz