Skip to content

Commit 44be851

Browse files
Merge pull request #30302 from juzhao/bump_limit
OCPBUGS-62227: bump telemetry series limit to 1000
2 parents ae47704 + 7c50620 commit 44be851

File tree

1 file changed

+8
-18
lines changed

1 file changed

+8
-18
lines changed

test/extended/prometheus/prometheus.go

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -529,22 +529,12 @@ var _ = g.Describe("[sig-instrumentation][Late] Alerts", func() {
529529
// we only consider series sent since the beginning of the test
530530
testDuration := exutil.DurationSinceStartInSeconds().String()
531531

532-
isManagedServiceCluster, err := exutil.IsManagedServiceCluster(ctx, oc.AdminKubeClient())
533-
o.Expect(err).NotTo(o.HaveOccurred())
534-
535-
// We want to limit the number of total series sent, the cluster:telemetry_selected_series:count
536-
// rule contains the count of the all the series that are sent via telemetry. It is permissible
537-
// for some scenarios to generate more series than 760, we just want the basic state to be below
538-
// a threshold.
539-
var averageSeriesLimit int
540-
switch {
541-
case isManagedServiceCluster:
542-
averageSeriesLimit = 850
543-
default:
544-
averageSeriesLimit = 780
545-
}
546-
547532
tests := map[string]bool{
533+
// We want to limit the number of total series sent, the cluster:telemetry_selected_series:count
534+
// rule contains the count of the all the series that are sent via telemetry. It is permissible
535+
// for some scenarios to generate more series than the limit, we just want the basic state to be below
536+
// a threshold.
537+
548538
// The following query can be executed against the telemetry server
549539
// to reevaluate the threshold value (replace the matcher on the version label accordingly):
550540
//
@@ -557,10 +547,10 @@ var _ = g.Describe("[sig-instrumentation][Late] Alerts", func() {
557547
// )[30m:1m]
558548
// )
559549
// )
560-
fmt.Sprintf(`avg_over_time(cluster:telemetry_selected_series:count[%s]) >= %d`, testDuration, averageSeriesLimit): false,
561-
fmt.Sprintf(`max_over_time(cluster:telemetry_selected_series:count[%s]) >= 1200`, testDuration): false,
550+
fmt.Sprintf(`avg_over_time(cluster:telemetry_selected_series:count[%s]) >= 1000`, testDuration): false,
551+
fmt.Sprintf(`max_over_time(cluster:telemetry_selected_series:count[%s]) >= 1200`, testDuration): false,
562552
}
563-
err = helper.RunQueries(context.TODO(), oc.NewPrometheusClient(context.TODO()), tests, oc)
553+
err := helper.RunQueries(context.TODO(), oc.NewPrometheusClient(context.TODO()), tests, oc)
564554
o.Expect(err).NotTo(o.HaveOccurred())
565555

566556
e2e.Logf("Total number of series sent via telemetry is below the limit")

0 commit comments

Comments
 (0)