Fix broken new/reused disruption test names causing inaccurate flakes

dgoodwin · dgoodwin · commit 4e9a21a5e70a · 2023-12-12T08:19:53.000-04:00
diff --git a/pkg/monitortests/kubeapiserver/disruptionlegacyapiservers/monitortest.go b/pkg/monitortests/kubeapiserver/disruptionlegacyapiservers/monitortest.go
@@ -36,8 +36,8 @@ func NewRecordAvailabilityOnly() monitortestframework.MonitorTest {
 	}
 }
 func testNames(owner, disruptionBackendName string) (string, string) {
-	return fmt.Sprintf("[%s] disruption/%s should be available throughout the test", owner, disruptionBackendName),
-		fmt.Sprintf("[%s] disruption/%s should be available throughout the test", owner, disruptionBackendName)
+	return fmt.Sprintf("[%s] disruption/%s connection/new should be available throughout the test", owner, disruptionBackendName),
+		fmt.Sprintf("[%s] disruption/%s connection/reused should be available throughout the test", owner, disruptionBackendName)
 }
 
 func newDisruptionCheckerForKubeAPI(adminRESTConfig *rest.Config) (*disruptionlibrary.Availability, error) {

Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,8 @@ func NewRecordAvailabilityOnly() monitortestframework.MonitorTest {`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`	`func testNames(owner, disruptionBackendName string) (string, string) {`
`39`		`- return fmt.Sprintf("[%s] disruption/%s should be available throughout the test", owner, disruptionBackendName),`
`40`		`- fmt.Sprintf("[%s] disruption/%s should be available throughout the test", owner, disruptionBackendName)`
	`39`	`+ return fmt.Sprintf("[%s] disruption/%s connection/new should be available throughout the test", owner, disruptionBackendName),`
	`40`	`+ fmt.Sprintf("[%s] disruption/%s connection/reused should be available throughout the test", owner, disruptionBackendName)`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`func newDisruptionCheckerForKubeAPI(adminRESTConfig rest.Config) (disruptionlibrary.Availability, error) {`