Skip to content

Conversation

@tchap
Copy link
Contributor

@tchap tchap commented Oct 24, 2025

These are finishing touches from a previous change: #30384
The process had to be gradual to be able to pass tests in origin and KASO PRs.

These are finishing touches from a previous change. The process had to
be gradual to be able to pass tests in origin and KASO PRs.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 24, 2025

@tchap: This pull request references CNTRLPLANE-1544 which is a valid jira issue.

In response to this:

These are finishing touches from a previous change: #30384
The process had to be gradual to be able to pass tests in origin and KASO PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ibihim and liouk October 24, 2025 21:13
@liouk
Copy link
Member

liouk commented Oct 27, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liouk, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2025
@tchap
Copy link
Contributor Author

tchap commented Oct 27, 2025

/verified by "[sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules"

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 27, 2025
@openshift-ci-robot
Copy link

@tchap: This PR has been marked as verified by "[sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules".

In response to this:

/verified by "[sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tchap
Copy link
Contributor Author

tchap commented Oct 27, 2025

/retest

@benluddy
Copy link
Contributor

/cc

@openshift-ci openshift-ci bot requested a review from benluddy October 27, 2025 15:25
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2025

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b60bbfe into openshift:main Oct 27, 2025
20 checks passed
@tchap tchap deleted the restricted-v3-finishing-touches branch November 21, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants