Skip a ClusterOperator test if a cluster upgrade is blocked #30558
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cluster upgrade is blocked before co/machine-config starts to update (
Progressing=True), thenmachineConfigProgressingStartis zero. In that case, the rule "each CO should stayProgressing=Falsewhile MCO isProgressing=True" is trivially valid, and thus we do not need to check it in the test.Without the guard introduced in this pull, the cases for COs that started update earlier in the upgrade would be failures by mistake which become noises on Component Readiness portal. See an example job [1]. There the upgrade was not complete because it is blocked by co/baremetal [2].
[1]. https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-upgrade-ovn-ipv6/1995270013593849856
[2]. https://issues.redhat.com/browse/OCPBUGS-66134