Skip to content

Conversation

@hongkailiu
Copy link
Member

If a cluster upgrade is blocked before co/machine-config starts to update (Progressing=True), then machineConfigProgressingStart is zero. In that case, the rule "each CO should stay Progressing=False while MCO is Progressing=True" is trivially valid, and thus we do not need to check it in the test.

Without the guard introduced in this pull, the cases for COs that started update earlier in the upgrade would be failures by mistake which become noises on Component Readiness portal. See an example job [1]. There the upgrade was not complete because it is blocked by co/baremetal [2].

[1]. https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-upgrade-ovn-ipv6/1995270013593849856

[2]. https://issues.redhat.com/browse/OCPBUGS-66134

If a cluster upgrade is blocked before co/machine-config starts to update
(`Progressing=True`), then `machineConfigProgressingStart` is zero. In
that case, the rule "each CO should stay `Progressing=False` while MCO is
`Progressing=True`" is trivially valid, and thus we do not need to check
it in the test.

Without the guard introduced in this pull, the cases for COs that
started update earlier in the upgrade would be failures by mistake
which become noises on Component Readiness portal. See an example
job [1]. There the upgrade was not complete because it is blocked
by co/baremetal [2].

[1]. https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-upgrade-ovn-ipv6/1995270013593849856

[2]. https://issues.redhat.com/browse/OCPBUGS-66134
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from deads2k and sjenning December 2, 2025 21:15
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@hongkailiu
Copy link
Member Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-2of2 f2dd7de link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-aws-ovn-serial-1of2 f2dd7de link true /test e2e-aws-ovn-serial-1of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants