OKD-259: Test OKD Feature set Against OKD and OCP clusters

[jatinsu]

This test checks for OKD and OCP clusters and attempts to enable the OKD featureset against them. If it's a OKD cluster, it should be able to enabled, but if it's a OCP cluster it should reject.

Kubenertes PR for context: openshift/kubernetes#2420

[openshift-ci-robot]

@jatinsu: This pull request references OKD-259 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This test checks for OKD and OCP clusters and attempts to enable the OKD featureset against them. If it's a OKD cluster, it should be able to enabled, but if it's a OCP cluster it should reject.

Kubenertes PR for context: openshift/kubernetes#2420

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jatinsu
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jatinsu]

The OKD feature set doesn't allow for a cluster to transition back to default. Should I

1. Have a check for when a cluster's original featureset is default so it doesn't fail
2. Completely omit this as OKD clusters should have the OKD featureset and wouldn't need to switch back to the original featureset

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-upgrade-rollback
/test e2e-metal-ovn-two-node-fencing

[openshift-ci]

@jatinsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn	4459b59	link	true	/test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-fips	4459b59	link	true	/test e2e-aws-ovn-fips
ci/prow/e2e-vsphere-ovn-upi	4459b59	link	true	/test e2e-vsphere-ovn-upi
ci/prow/e2e-gcp-ovn	4459b59	link	true	/test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6	4459b59	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ovn-two-node-fencing	4459b59	link	false	/test e2e-metal-ovn-two-node-fencing
ci/prow/e2e-aws-ovn-serial-1of2	4459b59	link	true	/test e2e-aws-ovn-serial-1of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-trt]

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 4459b59

Job Name	New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips	High - "[sig-api-machinery][Feature:FeatureGate][OCPFeatureGate:OKD] should validate OKD featureset based on cluster type [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-gcp-ovn	High - "[sig-api-machinery][Feature:FeatureGate][OCPFeatureGate:OKD] should validate OKD featureset based on cluster type [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6	High - "[sig-api-machinery][Feature:FeatureGate][OCPFeatureGate:OKD] should validate OKD featureset based on cluster type [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-vsphere-ovn	High - "[sig-api-machinery][Feature:FeatureGate][OCPFeatureGate:OKD] should validate OKD featureset based on cluster type [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi	High - "[sig-api-machinery][Feature:FeatureGate][OCPFeatureGate:OKD] should validate OKD featureset based on cluster type [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit

New tests seen in this PR at sha: 4459b59

• "[sig-api-machinery][Feature:FeatureGate][OCPFeatureGate:OKD] should validate OKD featureset based on cluster type [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 0, Fail: 5, Flake: 0]