[DNM] Layer2 router upgrade #2764
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nadia Pinaeva <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]>
This subnet is now also used for transit routers in the layer2 topology. Signed-off-by: Nadia Pinaeva <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]>
Make sure it reserves already allocated ids on startup. Signed-off-by: Nadia Pinaeva <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]>
Add transit router info to use for layer2 interconnect. Signed-off-by: Nadia Pinaeva <[email protected]> Co-authored-by: Enrique Llorente <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]> Co-authored-by: Enrique Llorente <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]> Co-authored-by: Enrique Llorente <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]> Co-authored-by: Enrique Llorente <[email protected]>
gateway: Remove old GW router to layer2 switch ports together with stale routes, policies and NATs. layer2_controller: Create an extra switch to transit router link with MAC-only router port. Add fake join subnet IPs to the transit router to switch port. Signed-off-by: Nadia Pinaeva <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]>
It is only triggered on restart now Signed-off-by: Nadia Pinaeva <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]>
"UDN pod to the same node nodeport service in different UDN network" test used to work on Layer2 UDN for ipv6 because of the SNAT on the GR. Now SNAT was moved to the transit router and works the same way as Layer3 networks. Signed-off-by: Nadia Pinaeva <[email protected]>
Previously default gateway for layer2 was on the GR, so we had to use it's primary joinIP to evaluate expected MAC and LLA, now the default gateway is on the transit router with the first subnet IP. Signed-off-by: Nadia Pinaeva <[email protected]>
cni/NetNS is replaced with github.com/containernetworking/plugins/pkg/ns/NetNS node.ManagementPort was moved to its own package. Signed-off-by: Nadia Pinaeva <[email protected]>
Fix unit tests for the introduced changes. Signed-off-by: Nadia Pinaeva <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]>
Co-authored-by: Enrique Llorente <[email protected]> Signed-off-by: Nadia Pinaeva <[email protected]>
Co-authored-by: Enrique Llorente <[email protected]> Signed-off-by: Nadia Pinaeva <[email protected]>
Add a transitSubnet field similar to joinSubnet to the NetConf, but only set it for Primary Layer2 networks. Set transit subnets for NADs Signed-off-by: Nadia Pinaeva <[email protected]>
|
/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-fdp-qe |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anuragthehatter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 tasks
|
/retest |
Add a transitSubnet field similar to joinSubnet to the NetConf, but only set it for Primary Layer2 networks. Set transit subnets for NADs Signed-off-by: Nadia Pinaeva <[email protected]> (cherry picked from commit 62bd1eb)
After topology upgrade a new default gateway for layer2 VMs will be on the transit router, so we need to remove previously learned MAC. Co-authored-by: Enrique Llorente <[email protected]> Signed-off-by: Nadia Pinaeva <[email protected]> (cherry picked from commit c94039c)
Co-authored-by: Enrique Llorente <[email protected]> Signed-off-by: Nadia Pinaeva <[email protected]> (cherry picked from commit 4d02af3)
|
Created #2776 to incorporate latest commits. This one seems to get messed up due to numerous conflicts. WTAL later. Meanwhile seeing SIGSEGV violations with latest changes causing ovn to crash |
|
@anuragthehatter: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
This is for D/S PR for QE testing
Ref: ovn-kubernetes/ovn-kubernetes#5561
cc @tssurya
Fixes #
Additional Information for reviewers
✅ Checks
How to verify it