[WIP] Refactor: Simplify ACL rule to use positive matching #2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: venkataanil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test |
|
@jtaleric: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
As using "!=" in ACL matches potentially cause a lot of openflow rules
to be created by ovn-controller, we want to avoid using negative
exclusion (!=) in OVN ACL for IPBlock.exclude fields.
- Use IPSetBuilder API to the build the allowed CIDR by excluding
IPBlock.except
- Then union of these allowed CIDRs will be done to get minimal CIDR
ranges, which will be joined into brace-delimited lists for ACL L3
matches (e.g., ip4.src == {p1, p2}).
- This reduces ACL churn by emitting a single match per IP family
when possible.
- This path maintains Kubernetes NetworkPolicy union semantics.
TODO: Need to fix the unit tests. Also please ignore my previous
commit where I tried with "drop" rules.
Signed-off-by: venkataanil <[email protected]>
venkataanil
force-pushed
the
acl_optimize
branch
from
db76f3e to
c926772
Compare
|
/test qe-perfscale-aws-ovn-small-udn-density-churn-l3 |
|
/test images |
|
@venkataanil: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As using "!=" in ACL matches potentially cause a lot of openflow rules to be created by ovn-controller, we want to avoid using negative exclusion (!=) in OVN ACL for IPBlock.exclude fields.
TODO: Need to fix the unit tests. Also please ignore my previous commit where I tried with "drop" rules.
This is D/S PR for Perf testing
Ref: ovn-kubernetes/ovn-kubernetes#5589