Skip to content

DNM: Add openflow to drop traffic for nodePort service #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DNM: Add openflow to drop traffic for nodePort service #2766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go-controller/pkg/node/bridgeconfig/bridgeconfig_testutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
func TestDefaultBridgeConfig() *BridgeConfiguration {
defaultNetConfig := &BridgeUDNConfiguration{
OfPortPatch: "patch-breth0_ov",
MasqCTMark: "0x1",
}
return &BridgeConfiguration{
netConfig: map[string]*BridgeUDNConfiguration{
Expand Down
12 changes: 12 additions & 0 deletions go-controller/pkg/node/gateway_localnet_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,6 +1193,10 @@ var _ = Describe("Node Operations", func() {
}
expectedNodePortFlows := []string{
"cookie=0x453ae29bcbbc08bd, priority=110, in_port=eth0, tcp, tp_dst=31111, actions=output:patch-breth0_ov",
fmt.Sprintf("cookie=0x453ae29bcbbc08bd, priority=109, in_port=patch-breth0_ov, dl_src=%s, tcp, tp_dst=31111, actions=drop",
gwMAC),
fmt.Sprintf("cookie=0x453ae29bcbbc08bd, priority=110, in_port=patch-breth0_ov, dl_src=%s, tcp, tp_dst=31111, ip, nw_src=%s, actions=ct(commit, zone=64000, exec(set_field:0x1->ct_mark)), output:NORMAL",
gwMAC, v4localnetGatewayIP),
fmt.Sprintf("cookie=0x453ae29bcbbc08bd, priority=110, in_port=patch-breth0_ov, dl_src=%s, tcp, tp_src=31111, actions=output:eth0",
gwMAC),
}
Expand Down Expand Up @@ -2306,6 +2310,10 @@ var _ = Describe("Node Operations", func() {
expectedFlows := []string{
// default
"cookie=0x453ae29bcbbc08bd, priority=110, in_port=eth0, tcp, tp_dst=31111, actions=output:patch-breth0_ov",
fmt.Sprintf("cookie=0x453ae29bcbbc08bd, priority=109, in_port=patch-breth0_ov, dl_src=%s, tcp, tp_dst=31111, actions=drop",
gwMAC),
fmt.Sprintf("cookie=0x453ae29bcbbc08bd, priority=110, in_port=patch-breth0_ov, dl_src=%s, tcp, tp_dst=31111, ip, nw_src=%s, actions=ct(commit, zone=64000, exec(set_field:0x1->ct_mark)), output:NORMAL",
gwMAC, v4localnetGatewayIP),
fmt.Sprintf("cookie=0x453ae29bcbbc08bd, priority=110, in_port=patch-breth0_ov, dl_src=%s, tcp, tp_src=31111, actions=output:eth0",
gwMAC),
}
Expand Down Expand Up @@ -2596,6 +2604,10 @@ var _ = Describe("Node Operations", func() {
expectedFlows := []string{
// default
"cookie=0x453ae29bcbbc08bd, priority=110, in_port=eth0, tcp, tp_dst=31111, actions=output:patch-breth0_ov",
fmt.Sprintf("cookie=0x453ae29bcbbc08bd, priority=109, in_port=patch-breth0_ov, dl_src=%s, tcp, tp_dst=31111, actions=drop",
gwMAC),
fmt.Sprintf("cookie=0x453ae29bcbbc08bd, priority=110, in_port=patch-breth0_ov, dl_src=%s, tcp, tp_dst=31111, ip, nw_src=%s, actions=ct(commit, zone=64000, exec(set_field:0x1->ct_mark)), output:NORMAL",
gwMAC, v4localnetGatewayIP),
fmt.Sprintf("cookie=0x453ae29bcbbc08bd, priority=110, in_port=patch-breth0_ov, dl_src=%s, tcp, tp_src=31111, actions=output:eth0",
gwMAC),
}
Expand Down
20 changes: 20 additions & 0 deletions go-controller/pkg/node/gateway_shared_intf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,11 +329,31 @@ func (npw *nodePortWatcher) updateServiceFlowCache(service *corev1.Service, netI
npw.ofm.updateFlowCacheEntry(key, nodeportFlows)
} else if config.Gateway.Mode == config.GatewayModeShared {
// case2 (see function description for details)
var ipProtocol, gwIP string
if strings.Contains(flowProtocol, "6") {
ipProtocol = "ip6"
gwIP = npw.gatewayIPv6
} else {
ipProtocol = "ip"
gwIP = npw.gatewayIPv4
}

npw.ofm.updateFlowCacheEntry(key, []string{
// table=0, matches on service traffic towards nodePort and sends it to OVN pipeline
fmt.Sprintf("cookie=%s, priority=110, in_port=%s, %s, tp_dst=%d, "+
"actions=%s",
cookie, npw.ofportPhys, flowProtocol, svcPort.NodePort, actions),
// table=0, matches on service traffic towards nodePort from OVN and drops it, to prevent the ingress traffic goes to the host.
// This is to prevent ingress traffic to nodePort from being forwarded to the host accidentally during GR OVN LB resyncs.
fmt.Sprintf("cookie=%s, priority=109, in_port=%s, dl_src=%s, %s, tp_dst=%d, "+
"actions=drop",
cookie, netConfig.OfPortPatch, npw.ofm.getDefaultBridgeMAC(), flowProtocol, svcPort.NodePort),
// table=0, matches on local host/pods egress traffic to service nodePort and sends it out to physical network.
// This is needed for the case where a local pod/host is trying to access the service via nodePort. It gets higher
// priority than the previous rule to allow local traffic to nodePort to be sent out.
fmt.Sprintf("cookie=%s, priority=110, in_port=%s, dl_src=%s, %s, tp_dst=%d, %s, nw_src=%s, "+
"actions=ct(commit, zone=%d, exec(set_field:%s->ct_mark)), output:NORMAL",
cookie, netConfig.OfPortPatch, npw.ofm.getDefaultBridgeMAC(), flowProtocol, svcPort.NodePort, ipProtocol, gwIP, config.Default.ConntrackZone, netConfig.MasqCTMark),
// table=0, matches on return traffic from service nodePort and sends it out to primary node interface (br-ex)
fmt.Sprintf("cookie=%s, priority=110, in_port=%s, dl_src=%s, %s, tp_src=%d, "+
"actions=output:%s",
Expand Down