DNM testing #2802
Open
DNM testing #2802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cgoncalves The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgoncalves
force-pushed
the
OCPBUGS-61833
branch
from
a00ccf6 to
22d5857
Compare
openshift-merge-robot
removed
the
needs-rebase
EgressIPs were incorrectly added to the br-ex network interface immediately upon EgressIP CR creation, without checking for matching pods or using longest prefix matching (LPM) for interface selection. This caused duplicate IP assignments when the correct secondary host interface was later assigned. Changes: - Add pod existence validation before IP assignment in bridgeEIPAddrManager - Implement longest prefix matching to determine correct network interface - Add dynamic pod event handling to re-evaluate EgressIPs on pod lifecycle - Extend retry framework to watch pod events for EgressIP reconciliation - Add comprehensive unit tests covering edge cases and pod matching logic The fix ensures EgressIPs are only assigned when: 1. Matching pods exist and are running 2. The target interface is determined via LPM algorithm 3. No duplicate IPs are assigned across multiple interfaces Files modified: - gateway_egressip.go: Core logic for pod checking and LPM interface selection - gateway.go: Pod event handling and retry framework integration - gateway_shared_intf.go: Bridge manager initialization with pod informers - obj_retry_gateway.go: Pod resource handling in retry framework - gateway_egressip_test.go: Comprehensive test coverage for new functionality Fixes duplicate EgressIP assignment bug where IPs appeared on both br-ex and the correct secondary interface simultaneously.
cgoncalves
force-pushed
the
OCPBUGS-61833
branch
from
22d5857 to
58e5fa3
Compare
|
@cgoncalves: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.