Skip to content

Conversation

@sunzhaohua2
Copy link
Contributor

@sunzhaohua2 sunzhaohua2 commented Jan 7, 2026

we need to merge pr openshift/cluster-capi-operator#442 first

@damdo
Copy link
Member

damdo commented Jan 7, 2026

/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-1of2 pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2

Let's see what gains we get

@openshift-ci-robot
Copy link
Contributor

@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sunzhaohua2
Copy link
Contributor Author

@damdo
Copy link
Member

damdo commented Jan 8, 2026

/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-1of2 pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2

@openshift-ci-robot
Copy link
Contributor

@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

/hold

For testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, sunzhaohua2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2026
@damdo
Copy link
Member

damdo commented Jan 8, 2026

Last run one of the two jobs ran for 3h 14m, not sure if we are actually gaining anything by parallelising, WDYT @sunzhaohua2 @theobarberbany 🤔

@damdo
Copy link
Member

damdo commented Jan 8, 2026

/hold

@sunzhaohua2
Copy link
Contributor Author

Last run one of the two jobs ran for 3h 14m, not sure if we are actually gaining anything by parallelising, WDYT @sunzhaohua2 @theobarberbany 🤔

@damdo Thank you for checking these two jobs, I raised a pr to add SHARD_ARGS, we need to merge openshift/cluster-capi-operator#442 first

@damdo
Copy link
Member

damdo commented Jan 9, 2026

/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-1of2 pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2

@openshift-ci-robot
Copy link
Contributor

@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@damdo
Copy link
Member

damdo commented Jan 9, 2026

/test pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

@damdo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test app-ci-config-dry
/test boskos-config
/test boskos-config-generation
/test build01-dry
/test build02-dry
/test build03-dry
/test build04-dry
/test build06-dry
/test build07-dry
/test build08-dry
/test build09-dry
/test build10-dry
/test check-gh-automation
/test check-gh-automation-tide
/test ci-operator-config
/test ci-operator-config-metadata
/test ci-operator-registry
/test ci-secret-bootstrap-config-validation
/test ci-testgrid-allow-list
/test clusterimageset-validate
/test config
/test core-valid
/test generated-config
/test generated-dashboards
/test hosted-mgmt-dry
/test image-mirroring-config-validation
/test jira-lifecycle-config
/test labels
/test openshift-image-mirror-mappings
/test ordered-prow-config
/test owners
/test pr-reminder-config
/test prow-config
/test prow-config-filenames
/test prow-config-semantics
/test pylint
/test release-config
/test release-controller-config
/test rover-groups-config-validation
/test secret-generator-config-valid
/test services-valid
/test stackrox-stackrox-stackrox-stackrox-check
/test step-registry-metadata
/test step-registry-shellcheck
/test sync-rover-groups
/test verified-config
/test vsphere02-dry
/test yamllint

The following commands are available to trigger optional jobs:

/test build05-dry
/test build11-dry
/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation
pull-ci-openshift-release-master-ci-operator-config
pull-ci-openshift-release-master-ci-operator-config-metadata
pull-ci-openshift-release-master-ci-operator-registry
pull-ci-openshift-release-master-config
pull-ci-openshift-release-master-core-valid
pull-ci-openshift-release-master-generated-config
pull-ci-openshift-release-master-ordered-prow-config
pull-ci-openshift-release-master-owners
pull-ci-openshift-release-master-prow-config-filenames
pull-ci-openshift-release-master-prow-config-semantics
pull-ci-openshift-release-master-release-controller-config
pull-ci-openshift-release-openshift-image-mirror-mappings
pull-ci-openshift-release-yamllint
Details

In response to this:

/test pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sunzhaohua2
Copy link
Contributor Author

This still doesn't work, all the cases were selected in both 2 jobs.

I checked with claude:
The issue is that --multi-stage-param=SHARD_ARGS="..." only works for multi-stage workflow refs, not inline commands. Our test step uses commands: make e2e, which is an inline command. Fix: Add explicit env declaration to the test step in ci-operator config:

env:
- name: SHARD_ARGS
  default: ""

This allows ci-operator to inject the param value into the test container's environment.

I will try to update based on this.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@sunzhaohua2: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-1of2 openshift/cluster-capi-operator presubmit Presubmit changed
pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2 openshift/cluster-capi-operator presubmit Presubmit changed
pull-ci-openshift-cluster-capi-operator-release-4.21-e2e-aws-capi-techpreview-1of2 openshift/cluster-capi-operator presubmit Presubmit changed
pull-ci-openshift-cluster-capi-operator-release-4.21-e2e-aws-capi-techpreview-2of2 openshift/cluster-capi-operator presubmit Presubmit changed
pull-ci-openshift-cluster-capi-operator-release-4.22-e2e-aws-capi-techpreview-1of2 openshift/cluster-capi-operator presubmit Presubmit changed
pull-ci-openshift-cluster-capi-operator-release-4.22-e2e-aws-capi-techpreview-2of2 openshift/cluster-capi-operator presubmit Presubmit changed
pull-ci-openshift-cluster-capi-operator-release-4.23-e2e-aws-capi-techpreview-1of2 openshift/cluster-capi-operator presubmit Presubmit changed
pull-ci-openshift-cluster-capi-operator-release-4.23-e2e-aws-capi-techpreview-2of2 openshift/cluster-capi-operator presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-capi-techpreview-1of2 openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-capi-techpreview-2of2 openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-release-4.21-e2e-aws-capi-techpreview-1of2 openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-release-4.21-e2e-aws-capi-techpreview-2of2 openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-release-4.22-e2e-aws-capi-techpreview-1of2 openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-release-4.22-e2e-aws-capi-techpreview-2of2 openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-release-4.23-e2e-aws-capi-techpreview-1of2 openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-release-4.23-e2e-aws-capi-techpreview-2of2 openshift/cluster-api-provider-aws presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@sunzhaohua2
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-1of2 pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2

@openshift-ci-robot
Copy link
Contributor

@sunzhaohua2: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

@sunzhaohua2: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-capi-operator/main/e2e-aws-capi-techpreview-1of2 2caba09 link unknown /pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-1of2
ci/rehearse/openshift/cluster-capi-operator/main/e2e-aws-capi-techpreview-2of2 2caba09 link unknown /pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sunzhaohua2
Copy link
Contributor Author

This still doesn't work, the SHARD_ARGS is openshift-tests parameters, but this command runs native Ginkgo tests, not openshift-tests.

Maybe we need use OTE to enable sharding support. I tried with CPMS in a test pr #73339, it works.

So the next step will be:

  1. merge the OTE pr: OCPCLOUD-3041: Created Cluster-api-tests-ext command for origin e2e cluster-capi-operator#413
  2. then update this pr like
- as: e2e-aws-capi-techpreview
  shard_count: 2
  steps:
    cluster_profile: aws-5
    env:
      FEATURE_SET: TechPreviewNoUpgrade
      TEST_SUITE: capio/e2e  # Use OTE suite instead of make command
    workflow: openshift-e2e-aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants