-
Notifications
You must be signed in to change notification settings - Fork 2.1k
use shard_count for e2e-aws-capi-techpreview jobs #73182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-1of2 pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2 Let's see what gains we get |
|
@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
3e7acd5 to
521641e
Compare
|
@damdo the 2 jobs passed, there was a code conflict, so I rebased them. |
|
/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-1of2 pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2 |
|
@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/hold
For testing
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo, sunzhaohua2 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Last run one of the two jobs ran for 3h 14m, not sure if we are actually gaining anything by parallelising, WDYT @sunzhaohua2 @theobarberbany 🤔 |
|
/hold |
@damdo Thank you for checking these two jobs, I raised a pr to add SHARD_ARGS, we need to merge openshift/cluster-capi-operator#442 first |
|
/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-1of2 pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2 |
|
@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/test pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2 |
|
@damdo: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This still doesn't work, all the cases were selected in both 2 jobs. I checked with claude: This allows ci-operator to inject the param value into the test container's environment. I will try to update based on this. |
521641e to
2caba09
Compare
|
New changes are detected. LGTM label has been removed. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-1of2 pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-2of2 |
|
@sunzhaohua2: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@sunzhaohua2: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This still doesn't work, the SHARD_ARGS is openshift-tests parameters, but this command runs native Ginkgo tests, not openshift-tests. Maybe we need use OTE to enable sharding support. I tried with CPMS in a test pr #73339, it works. So the next step will be:
|
we need to merge pr openshift/cluster-capi-operator#442 first