Fedora image

[snir911]

No description provided.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[red-hat-konflux]

Caution

There are some errors in your PipelineRun template.

PipelineRun	Error
osc-registry	no kind "ImageDigestMirrorSet" is registered for version "config.openshift.io/v1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"

[Copilot]

Pull Request Overview

This PR introduces NVIDIA support and a Fedora-based PodVM image variant, adding necessary service definitions, scripts, container build logic, and workflow updates.

• Add a systemd service and script to generate NVIDIA CDI configuration
• Extend the Fedora Containerfile with an NVIDIA build target and related setup
• Update GitHub Actions workflow and documentation to include the NVIDIA variant

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
config/peerpods/podvm/bootc/nvidia/nvidia-cdi.service	New systemd unit to kick off NVIDIA CDI generation
config/peerpods/podvm/bootc/nvidia/generate-nvidia-cdi.sh	Script to load drivers and produce NVIDIA CDI YAML
config/peerpods/podvm/bootc/Containerfile.fedora	Added NVIDIA build stage, driver install, and CDI setup
.github/workflows/bootc-podvm-build.yaml	Workflow jobs for NVIDIA container/disk image builds
.github/README.md	Documentation for bootc PodVM build workflows

Comments suppressed due to low confidence (4)

.github/workflows/bootc-podvm-build.yaml:116

• The comparison build_disk != 'false' treats a boolean input as string; use if: github.event.inputs.build_disk instead to correctly gate the disk build.

    if: github.event_name != 'pull_request' && (github.event.inputs.build_disk != 'false') && (always() && !cancelled() && !failure())

.github/workflows/bootc-podvm-build.yaml:80

• This condition will run the NVIDIA build on every push/PR regardless of provider; restrict it to Azure only by removing the non-workflow_dispatch clause.

    if: github.event.inputs.cloud_provider == 'azure' || github.event_name != 'workflow_dispatch'

.github/README.md:20

• The README mentions triggers on main, but the workflow file only triggers on devel. Please synchronize the branch list in the docs.

- **Push events** to `main` or `devel` branches when bootc files change

config/peerpods/podvm/bootc/nvidia/generate-nvidia-cdi.sh:10

• Ensure the target directories (/var/run/cdi and /var/log) exist or create them in the script to avoid write errors.

nvidia-ctk cdi generate --output=/var/run/cdi/nvidia.yaml > /var/log/nvidia-cdi-gen.log 2>&1

[openshift-ci]

@snir911: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.