Skip to content

Conversation

@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jan 15, 2026

/cc @

Summary by CodeRabbit

  • Chores
    • Updated CI/CD test configuration with refinements to the testing matrix.
    • Removed long-duration and specialized testing variants for legacy releases.
    • Added new conformance testing for MicroShift on release 4.20.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026

Walkthrough

Updated config/openshift.yaml timestamp and adjusted periodic job declarations: removed some legacy hive/oadp entries, deduplicated/added several periodic jobs (notably microshift and agent QE jobs), and expanded lists of periodic job names in multiple release sections.

Changes

Cohort / File(s) Summary
OpenShift CI config
config/openshift.yaml
Updated generation timestamp; removed specific periodic job entries (several oadp and hive weekly jobs); added/duplicated periodic entries for agent QE and microshift releases; inserted two microshift periodic job names into release job lists; small reordering and deduplication of periodic job keys.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 6 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Automated - Update config ./config/openshift.yaml' is generic and vague, using standard automation language without conveying meaningful information about what changed. Consider a more descriptive title that summarizes the key changes, such as 'Update OpenShift configuration with job removals and additions for 4.20 release testing' to better communicate the changeset purpose.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Go Error Handling ✅ Passed The custom check for Go error handling patterns is not applicable to this pull request. The pull request exclusively modifies config/openshift.yaml, a YAML configuration file containing CI job definitions and test configurations for the OpenShift testing infrastructure. Since this is a configuration file and not Go source code, it cannot contain Go error handling violations.
Sql Injection Prevention ✅ Passed PR only modifies config/openshift.yaml, not source code files that could contain SQL queries or injection vulnerabilities.
Excessive Css In React Should Use Styles ✅ Passed This check is not applicable to the provided pull request. The PR exclusively modifies config/openshift.yaml, a YAML configuration file for OpenShift CI/Prow job definitions. The check is designed to assess React components for excessive inline CSS and recommend the useStyles pattern. Since this file contains no React components, JSX, CSS properties, inline style objects, or any styling code whatsoever—only YAML configuration entries for CI job definitions—the check does not apply to this context.
Single Responsibility And Clear Naming ✅ Passed The custom check is not applicable to this pull request. This PR contains only updates to a YAML configuration file with no source code modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from neisw and smg247 January 15, 2026 10:12
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-bot
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 087457d and 2 for PR HEAD 551b8da in total

@openshift-bot openshift-bot force-pushed the automated---update-config-./config/openshift.yaml branch from 551b8da to e6a99a7 Compare January 15, 2026 22:05
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@config/openshift.yaml`:
- Line 16175: Several auto-generated job names contain a typo: "invaid-fields"
should be "invalid-fields" (e.g.
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-nutanix-ipi-zones-invaid-fields-f28
and the corresponding vsphere-ipi variants across 4.16–4.22); fix this by
updating the upstream job definitions used by openshift/ci-tools
sippy-config-generator to replace "invaid-fields" with "invalid-fields" for the
nutanix-ipi-zones and vsphere-ipi job name patterns (14 occurrences total), then
re-run the generator to regenerate config so the generated openshift.yaml no
longer contains the typo.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 551b8da and e6a99a7.

📒 Files selected for processing (2)
  • config/openshift.yaml
  • pkg/variantregistry/snapshot.yaml
🔇 Additional comments (9)
config/openshift.yaml (9)

1-1: LGTM!

Auto-generated timestamp header is standard for machine-generated configuration files.


8850-8851: LGTM!

New OADP QE automation jobs for AWS testing follow the established naming convention and are properly placed in alphabetical order within the 4.19 release configuration.


9051-9051: LGTM!

CNF RAN ZTP test job addition is consistent with existing CNF job patterns.


10828-10828: LGTM!

Baremetal OVE compact agent jobs added consistently for both 4.20 and 4.21 releases.

Also applies to: 12760-12760


11675-11676: LGTM!

Multi-arch baremetal jobs added consistently across releases 4.20, 4.21, and 4.22 with proper f28 frequency designation.

Also applies to: 13636-13637, 15589-15590


12235-12236: LGTM!

MicroShift OCP conformance jobs (including serial variant) added consistently across releases 4.20, 4.21, and 4.22.

Also applies to: 14290-14291, 16212-16213


12841-12844: LGTM!

Four new Hive weekly e2e jobs added for release 4.21, covering Azure, GCP, pool, and general weekly test schedules. The jobs reference master branch which is typical for Hive periodic jobs that track the latest code while being associated with a specific OCP release.


16074-16184: Comprehensive verification test coverage for 4.22.

Large addition of ~110 verification tests covering multiple cloud providers (AWS, Azure, GCP, IBM Cloud, Nutanix, vSphere) with various configuration scenarios including:

  • IPI/UPI installation methods
  • IAM profiles and roles
  • Network configurations (proxy, DNS, subnets)
  • Disk types and boot diagnostics
  • OIDC and identity management
  • Multi-arch and ARM configurations

The YAML multi-line key syntax (using ? and :) for long job names is correctly applied.


16146-16146: No action needed. The job name non-emtyp-rg is the correct name from the upstream CI system, not a typo. It appears consistently across multiple OpenShift versions (4.18–4.22) in both the configuration and the variant registry snapshot.

Likely an incorrect or invalid review comment.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

: true
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-ibmcloud-ipi-private-sshkey-f28: true
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-ibmcloud-ipi-subnet-paging-f28: true
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-nutanix-ipi-zones-invaid-fields-f28: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# First, verify the file exists and check the specific lines
wc -l config/openshift.yaml
echo "=== Checking line 16175 ==="
sed -n '16175p' config/openshift.yaml
echo "=== Checking line 16181 ==="
sed -n '16181p' config/openshift.yaml

Repository: openshift/sippy

Length of output: 388


🏁 Script executed:

# Search for all occurrences of invaid-fields and invalid-fields
echo "=== Searching for invaid-fields ==="
rg -n "invaid-fields" config/openshift.yaml
echo "=== Searching for invalid-fields ==="
rg -n "invalid-fields" config/openshift.yaml

Repository: openshift/sippy

Length of output: 1931


🏁 Script executed:

# Check if there's any header/metadata indicating auto-generation
head -50 config/openshift.yaml

Repository: openshift/sippy

Length of output: 3556


Fix typo in upstream job definitions: "invaid" should be "invalid".

The file contains 14 job names with invaid-fields across OpenShift versions 4.16–4.22. Both the nutanix-ipi-zones and vsphere-ipi variants are affected. Since this is auto-generated configuration from openshift/ci-tools sippy-config-generator, the fix should be applied to the upstream job definitions rather than in this generated file.

🤖 Prompt for AI Agents
In `@config/openshift.yaml` at line 16175, Several auto-generated job names
contain a typo: "invaid-fields" should be "invalid-fields" (e.g.
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-nutanix-ipi-zones-invaid-fields-f28
and the corresponding vsphere-ipi variants across 4.16–4.22); fix this by
updating the upstream job definitions used by openshift/ci-tools
sippy-config-generator to replace "invaid-fields" with "invalid-fields" for the
nutanix-ipi-zones and vsphere-ipi job name patterns (14 occurrences total), then
re-run the generator to regenerate config so the generated openshift.yaml no
longer contains the typo.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 087457d and 2 for PR HEAD e6a99a7 in total

@openshift-bot openshift-bot force-pushed the automated---update-config-./config/openshift.yaml branch from e6a99a7 to ddf5a33 Compare January 16, 2026 10:05
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@config/openshift.yaml`:
- Line 16147: The job name
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28
contains a typo ("emtyp" → "empty"); fix the upstream job definition in the
source repository (where the job is defined for openshift/ci-tools
sippy-config-generator), rename the job to
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-empty-rg-f28,
then re-run the sippy-config-generator to regenerate config/openshift.yaml so
the corrected job name is propagated.
♻️ Duplicate comments (1)
config/openshift.yaml (1)

16178-16184: Typo in upstream job definitions: "invaid" should be "invalid" (duplicate).

Lines 16178 and 16184 contain job names with the typo invaid-fields instead of invalid-fields. This issue was already flagged in a previous review comment. Since this is auto-generated configuration, the fix should be applied upstream in the job definitions used by openshift/ci-tools sippy-config-generator.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between e6a99a7 and ddf5a33.

📒 Files selected for processing (2)
  • config/openshift.yaml
  • pkg/variantregistry/snapshot.yaml
🔇 Additional comments (2)
config/openshift.yaml (2)

12841-12844: New Hive periodic weekly jobs for release 4.21 look good.

The addition of four Hive e2e weekly test jobs (azure-weekly, gcp-weekly, pool-weekly, e2e-weekly) extends the periodic testing coverage as expected. The jobs follow the established naming conventions.


16075-16187: Extensive 4.22 verification test coverage addition.

This block adds comprehensive verification test jobs for release 4.22 covering AWS, Azure (including MAG and Stack variants), GCP, IBM Cloud, Nutanix, and vSphere platforms. The jobs follow established patterns from earlier releases. Apart from the typos noted separately, the configuration additions are consistent and correctly structured.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-duplicate-dns-arm-f28: true
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-instance-type-f28: true
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-mixed-publish-f28: true
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo in upstream job definition: "emtyp" should be "empty".

The job name periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28 contains a typo. Since this configuration is auto-generated from openshift/ci-tools sippy-config-generator, the fix should be applied to the upstream job definitions in the source repository.

🤖 Prompt for AI Agents
In `@config/openshift.yaml` at line 16147, The job name
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28
contains a typo ("emtyp" → "empty"); fix the upstream job definition in the
source repository (where the job is defined for openshift/ci-tools
sippy-config-generator), rename the job to
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-empty-rg-f28,
then re-run the sippy-config-generator to regenerate config/openshift.yaml so
the corrected job name is propagated.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 087457d and 2 for PR HEAD ddf5a33 in total

@openshift-bot openshift-bot force-pushed the automated---update-config-./config/openshift.yaml branch from ddf5a33 to 4062ff5 Compare January 16, 2026 22:05
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 087457d and 2 for PR HEAD 4062ff5 in total

@openshift-bot openshift-bot force-pushed the automated---update-config-./config/openshift.yaml branch from 4062ff5 to c897567 Compare January 17, 2026 10:05
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 087457d and 2 for PR HEAD c897567 in total

@openshift-bot openshift-bot force-pushed the automated---update-config-./config/openshift.yaml branch from c897567 to 0e83203 Compare January 17, 2026 22:05
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 087457d and 2 for PR HEAD 0e83203 in total

@openshift-bot openshift-bot force-pushed the automated---update-config-./config/openshift.yaml branch from 0e83203 to b14ad55 Compare January 18, 2026 10:05
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 087457d and 2 for PR HEAD b14ad55 in total

@openshift-bot openshift-bot force-pushed the automated---update-config-./config/openshift.yaml branch from b14ad55 to 5a10210 Compare January 18, 2026 22:05
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 087457d and 2 for PR HEAD 5a10210 in total

@openshift-bot openshift-bot force-pushed the automated---update-config-./config/openshift.yaml branch from 5a10210 to 746cb33 Compare January 19, 2026 10:05
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 087457d and 2 for PR HEAD 746cb33 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@openshift-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 746cb33 link true /test lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants