-
Notifications
You must be signed in to change notification settings - Fork 97
Automated - Update config ./config/openshift.yaml #3206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Automated - Update config ./config/openshift.yaml #3206
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
WalkthroughUpdated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
551b8da to
e6a99a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@config/openshift.yaml`:
- Line 16175: Several auto-generated job names contain a typo: "invaid-fields"
should be "invalid-fields" (e.g.
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-nutanix-ipi-zones-invaid-fields-f28
and the corresponding vsphere-ipi variants across 4.16–4.22); fix this by
updating the upstream job definitions used by openshift/ci-tools
sippy-config-generator to replace "invaid-fields" with "invalid-fields" for the
nutanix-ipi-zones and vsphere-ipi job name patterns (14 occurrences total), then
re-run the generator to regenerate config so the generated openshift.yaml no
longer contains the typo.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
config/openshift.yamlpkg/variantregistry/snapshot.yaml
🔇 Additional comments (9)
config/openshift.yaml (9)
1-1: LGTM!Auto-generated timestamp header is standard for machine-generated configuration files.
8850-8851: LGTM!New OADP QE automation jobs for AWS testing follow the established naming convention and are properly placed in alphabetical order within the 4.19 release configuration.
9051-9051: LGTM!CNF RAN ZTP test job addition is consistent with existing CNF job patterns.
10828-10828: LGTM!Baremetal OVE compact agent jobs added consistently for both 4.20 and 4.21 releases.
Also applies to: 12760-12760
11675-11676: LGTM!Multi-arch baremetal jobs added consistently across releases 4.20, 4.21, and 4.22 with proper f28 frequency designation.
Also applies to: 13636-13637, 15589-15590
12235-12236: LGTM!MicroShift OCP conformance jobs (including serial variant) added consistently across releases 4.20, 4.21, and 4.22.
Also applies to: 14290-14291, 16212-16213
12841-12844: LGTM!Four new Hive weekly e2e jobs added for release 4.21, covering Azure, GCP, pool, and general weekly test schedules. The jobs reference
masterbranch which is typical for Hive periodic jobs that track the latest code while being associated with a specific OCP release.
16074-16184: Comprehensive verification test coverage for 4.22.Large addition of ~110 verification tests covering multiple cloud providers (AWS, Azure, GCP, IBM Cloud, Nutanix, vSphere) with various configuration scenarios including:
- IPI/UPI installation methods
- IAM profiles and roles
- Network configurations (proxy, DNS, subnets)
- Disk types and boot diagnostics
- OIDC and identity management
- Multi-arch and ARM configurations
The YAML multi-line key syntax (using
?and:) for long job names is correctly applied.
16146-16146: No action needed. The job namenon-emtyp-rgis the correct name from the upstream CI system, not a typo. It appears consistently across multiple OpenShift versions (4.18–4.22) in both the configuration and the variant registry snapshot.Likely an incorrect or invalid review comment.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| : true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-ibmcloud-ipi-private-sshkey-f28: true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-ibmcloud-ipi-subnet-paging-f28: true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-nutanix-ipi-zones-invaid-fields-f28: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
# First, verify the file exists and check the specific lines
wc -l config/openshift.yaml
echo "=== Checking line 16175 ==="
sed -n '16175p' config/openshift.yaml
echo "=== Checking line 16181 ==="
sed -n '16181p' config/openshift.yamlRepository: openshift/sippy
Length of output: 388
🏁 Script executed:
# Search for all occurrences of invaid-fields and invalid-fields
echo "=== Searching for invaid-fields ==="
rg -n "invaid-fields" config/openshift.yaml
echo "=== Searching for invalid-fields ==="
rg -n "invalid-fields" config/openshift.yamlRepository: openshift/sippy
Length of output: 1931
🏁 Script executed:
# Check if there's any header/metadata indicating auto-generation
head -50 config/openshift.yamlRepository: openshift/sippy
Length of output: 3556
Fix typo in upstream job definitions: "invaid" should be "invalid".
The file contains 14 job names with invaid-fields across OpenShift versions 4.16–4.22. Both the nutanix-ipi-zones and vsphere-ipi variants are affected. Since this is auto-generated configuration from openshift/ci-tools sippy-config-generator, the fix should be applied to the upstream job definitions rather than in this generated file.
🤖 Prompt for AI Agents
In `@config/openshift.yaml` at line 16175, Several auto-generated job names
contain a typo: "invaid-fields" should be "invalid-fields" (e.g.
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-nutanix-ipi-zones-invaid-fields-f28
and the corresponding vsphere-ipi variants across 4.16–4.22); fix this by
updating the upstream job definitions used by openshift/ci-tools
sippy-config-generator to replace "invaid-fields" with "invalid-fields" for the
nutanix-ipi-zones and vsphere-ipi job name patterns (14 occurrences total), then
re-run the generator to regenerate config so the generated openshift.yaml no
longer contains the typo.
e6a99a7 to
ddf5a33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@config/openshift.yaml`:
- Line 16147: The job name
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28
contains a typo ("emtyp" → "empty"); fix the upstream job definition in the
source repository (where the job is defined for openshift/ci-tools
sippy-config-generator), rename the job to
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-empty-rg-f28,
then re-run the sippy-config-generator to regenerate config/openshift.yaml so
the corrected job name is propagated.
♻️ Duplicate comments (1)
config/openshift.yaml (1)
16178-16184: Typo in upstream job definitions: "invaid" should be "invalid" (duplicate).Lines 16178 and 16184 contain job names with the typo
invaid-fieldsinstead ofinvalid-fields. This issue was already flagged in a previous review comment. Since this is auto-generated configuration, the fix should be applied upstream in the job definitions used byopenshift/ci-tools sippy-config-generator.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
config/openshift.yamlpkg/variantregistry/snapshot.yaml
🔇 Additional comments (2)
config/openshift.yaml (2)
12841-12844: New Hive periodic weekly jobs for release 4.21 look good.The addition of four Hive e2e weekly test jobs (azure-weekly, gcp-weekly, pool-weekly, e2e-weekly) extends the periodic testing coverage as expected. The jobs follow the established naming conventions.
16075-16187: Extensive 4.22 verification test coverage addition.This block adds comprehensive verification test jobs for release 4.22 covering AWS, Azure (including MAG and Stack variants), GCP, IBM Cloud, Nutanix, and vSphere platforms. The jobs follow established patterns from earlier releases. Apart from the typos noted separately, the configuration additions are consistent and correctly structured.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-duplicate-dns-arm-f28: true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-instance-type-f28: true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-mixed-publish-f28: true | ||
| periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in upstream job definition: "emtyp" should be "empty".
The job name periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28 contains a typo. Since this configuration is auto-generated from openshift/ci-tools sippy-config-generator, the fix should be applied to the upstream job definitions in the source repository.
🤖 Prompt for AI Agents
In `@config/openshift.yaml` at line 16147, The job name
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-emtyp-rg-f28
contains a typo ("emtyp" → "empty"); fix the upstream job definition in the
source repository (where the job is defined for openshift/ci-tools
sippy-config-generator), rename the job to
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-valid-non-empty-rg-f28,
then re-run the sippy-config-generator to regenerate config/openshift.yaml so
the corrected job name is propagated.
ddf5a33 to
4062ff5
Compare
4062ff5 to
c897567
Compare
c897567 to
0e83203
Compare
0e83203 to
b14ad55
Compare
b14ad55 to
5a10210
Compare
5a10210 to
746cb33
Compare
|
@openshift-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cc @
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.