Merge https://github.com/topolvm/topolvm:main (95c9fda) into main #215
Conversation
![edge-enablement-team-rebase-bot[bot]](https://avatars.githubusercontent.com/u/792337?s=60&v=4){kind=small}
In DaemonSet mode, LVMd currently executes every LVM command through /usr/bin/nsenter with hard-coded arguments. This prevents users from: - Changing the path to nsenter or its options - Wrapping the command in a logging program or other tool - Running LVM commands without nsenter (though this is risky) This commint introduces the lvm-command-prefix option in lvmd.conf to provide that flexibility. The value is a list of strings that will be prepended to every command invocation. For example, if it is set to X, LV creation will be invoked as `X /sbin/lvm lvcreate ...`. The default value of this option is equivalent to `/usr/bin/nsenter -m -u -i -n -p -t 1`, so the current behaviour will not break by default. Signed-off-by: Ryotaro Banno <[email protected]>
This commit adds the `lvmd.additionalLVMDYamlContent` key to values.yaml, enabling users to append extra settings to the generated lvmd.yaml file. Please note that this option is different from `lvmd.additionalConfigs`, which creates a separate lvmd.yaml ConfigMap instead of modifying the existing one. Signed-off-by: Ryotaro Banno <[email protected]>
We have two options to adapt LVM command invocation i.e., --lvm-path option and lvm-command-prefix setting. The lvm-command-prefix setting is more general than --lvm-path, so the --lvm-path option is not necessary anymore. This commit deprecates the option. Users should use lvm-command-prefix instead. Signed-off-by: Ryotaro Banno <[email protected]>
lvmd: support lvm-command-prefix option in lvmd.conf
openshift-ci
bot
added
size/M
|
Hi @edge-enablement-team-rebase-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
edge-enablement-team-cloner-bot
bot
force-pushed
the
rebase-bot-main
branch
from
7d0b890 to
eeb8a2c
Compare
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.23.0 to 0.27.0. - [Commits](golang/oauth2@v0.23.0...v0.27.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-version: 0.27.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…lang.org/x/oauth2-0.27.0 chore(deps): bump golang.org/x/oauth2 from 0.23.0 to 0.27.0
Signed-off-by: Ryotaro Banno <[email protected]>
The current end-to-end test documentation shows how to run the tests directly on the host machine. Because they use Minikube's none driver, this can unexpectedly modify the host's environment. This commit adds instructions for running the tests in a Multipass VM instead, so developers can execute them without cluttering or altering their local environments. Signed-off-by: Ryotaro Banno <[email protected]>
edge-enablement-team-rebase-bot
bot
changed the title
edge-enablement-team-cloner-bot
bot
force-pushed
the
rebase-bot-main
branch
from
eeb8a2c to
13243f1
Compare
…ipass-script test/e2e: add a script to run minikube e2e tests on multipass
edge-enablement-team-rebase-bot
bot
changed the title
edge-enablement-team-cloner-bot
bot
force-pushed
the
rebase-bot-main
branch
from
13243f1 to
58b6039
Compare
openshift-ci
bot
added
size/L
…ributing-md docs: refresh TOC of CONTRIBUTING.md
edge-enablement-team-rebase-bot
bot
changed the title
edge-enablement-team-cloner-bot
bot
force-pushed
the
rebase-bot-main
branch
from
58b6039 to
d7f0656
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bump chart version to 15.6.0
edge-enablement-team-rebase-bot
bot
changed the title
edge-enablement-team-cloner-bot
bot
force-pushed
the
rebase-bot-main
branch
from
d7f0656 to
189289f
Compare
This fixes wrong indentation and subsequent YAML/JSON serialiazation failures if the are more than just a simple (empty list) content. Signed-off-by: Vlastimil Holer <[email protected]>
charts: lvmd: fix indentation for lvmd.additionalLVMDYamlContent
edge-enablement-team-rebase-bot
bot
changed the title
edge-enablement-team-cloner-bot
bot
force-pushed
the
rebase-bot-main
branch
from
189289f to
e70f97d
Compare
fix: re-enabling fips and trying brew golang builder test: switching to fedora because rhsm is giving issues
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: Suleyman Akbas <[email protected]>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
edge-enablement-team-rebase-bot
bot
changed the title
edge-enablement-team-cloner-bot
bot
force-pushed
the
rebase-bot-main
branch
from
e70f97d to
4a1cfef
Compare
|
/label ok-to-test |
|
@qJkee: Can not set label ok-to-test: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight openshift-sustaining-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label ok-to-test |
|
/lgtm |
|
@suleymanakbas91: Can not set label ok-to-test: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight openshift-sustaining-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edge-enablement-team-rebase-bot[bot], suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
@edge-enablement-team-rebase-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.