Skip to content

OCPBUGS-60159: add permissions for checking if users is authorized to see metrics #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhrmo wants to merge 1 commit into from
Closed

OCPBUGS-60159: add permissions for checking if users is authorized to see metrics #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions assets/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ spec:
- --tls-private-key-file=/etc/tls/private/tls.key
- --tls-cipher-suites=${TLS_CIPHER_SUITES}
- --tls-min-version=${TLS_MIN_VERSION}
- --allow-paths=/metrics
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
Expand Down Expand Up @@ -159,6 +160,7 @@ spec:
- --tls-private-key-file=/etc/tls/private/tls.key
- --tls-cipher-suites=${TLS_CIPHER_SUITES}
- --tls-min-version=${TLS_MIN_VERSION}
- --allow-paths=/metrics
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
Expand Down Expand Up @@ -206,6 +208,7 @@ spec:
- --tls-private-key-file=/etc/tls/private/tls.key
- --tls-cipher-suites=${TLS_CIPHER_SUITES}
- --tls-min-version=${TLS_MIN_VERSION}
- --allow-paths=/metrics
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
Expand Down Expand Up @@ -252,6 +255,7 @@ spec:
- --tls-private-key-file=/etc/tls/private/tls.key
- --tls-cipher-suites=${TLS_CIPHER_SUITES}
- --tls-min-version=${TLS_MIN_VERSION}
- --allow-paths=/metrics
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
Expand Down Expand Up @@ -299,6 +303,7 @@ spec:
- --tls-private-key-file=/etc/tls/private/tls.key
- --tls-cipher-suites=${TLS_CIPHER_SUITES}
- --tls-min-version=${TLS_MIN_VERSION}
- --allow-paths=/metrics
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
Expand Down Expand Up @@ -370,6 +375,7 @@ spec:
- --tls-private-key-file=/etc/tls/private/tls.key
- --tls-cipher-suites=${TLS_CIPHER_SUITES}
- --tls-min-version=${TLS_MIN_VERSION}
- --allow-paths=/metrics
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
Expand Down
5 changes: 4 additions & 1 deletion assets/rbac/kube_rbac_proxy_binding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Allow kube-rbac-proxies to create tokenreviews to check Prometheus identity when scraping metrics.
# Allow kube-rbac-proxies to create tokenreviews and subjectaccessreviews to check Prometheus identity when scraping metrics.
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
Expand All @@ -7,6 +7,9 @@ subjects:
- kind: ServiceAccount
name: vmware-vsphere-csi-driver-controller-sa
namespace: openshift-cluster-csi-drivers
- kind: ServiceAccount
name: vmware-vsphere-csi-driver-operator
namespace: openshift-cluster-csi-drivers
roleRef:
kind: ClusterRole
name: vmware-vsphere-kube-rbac-proxy-role
Expand Down
8 changes: 7 additions & 1 deletion assets/rbac/kube_rbac_proxy_role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Allow kube-rbac-proxies to create tokenreviews to check Prometheus identity when scraping metrics.
# Allow kube-rbac-proxies to create tokenreviews and subjectaccessreviews to check Prometheus identity when scraping metrics.
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
Expand All @@ -10,3 +10,9 @@ rules:
- "tokenreviews"
verbs:
- "create"
- apiGroups:
- "authorization.k8s.io"
resources:
- "subjectaccessreviews"
verbs:
- "create"