Skip to content

[release-4.19] OCPBUGS-60967: Fix job success logic #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

[release-4.19] OCPBUGS-60967: Fix job success logic #3234

merged 1 commit into from
Aug 29, 2025

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 27, 2025

This is an automated cherry-pick of #3202

/assign sebsoto

@sebsoto
Fix job success logic
f8d30c2 
We are reporting jobs as failed if a pod within the job failed. This is
incorrect logic, as a single pod failing is not a failure state for the
entire job. The job will keep creating pods until a success is seen.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 27, 2025
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 27, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-60771 has been cloned as Jira Issue OCPBUGS-60967. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-60967: Fix job success logic

In response to this:

This is an automated cherry-pick of #3202

/assign sebsoto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-60771: Fix job success logic [release-4.19] OCPBUGS-60967: Fix job success logic Aug 27, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 27, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-60967, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-60771 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3202

/assign sebsoto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sebsoto
Copy link
Contributor

sebsoto commented Aug 28, 2025

/approve

@sebsoto
Copy link
Contributor

sebsoto commented Aug 28, 2025

/lgtm

@sebsoto
Copy link
Contributor

sebsoto commented Aug 28, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2025

@sebsoto: This pull request references Jira Issue OCPBUGS-60967, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sebsoto
Copy link
Contributor

sebsoto commented Aug 28, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2025

@sebsoto: This pull request references Jira Issue OCPBUGS-60967, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-60771 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-60771 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @rrasouli

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 28, 2025
@openshift-ci openshift-ci bot requested a review from rrasouli August 28, 2025 12:12
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2025

/retest-required

Remaining retests: 0 against base HEAD 8247257 and 2 for PR HEAD f8d30c2 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2025

/retest-required

Remaining retests: 0 against base HEAD f94a3e8 and 1 for PR HEAD f8d30c2 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2025

/retest-required

Remaining retests: 0 against base HEAD af047c3 and 0 for PR HEAD f8d30c2 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 29, 2025

/hold

Revision f8d30c2 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2025
@sebsoto
Copy link
Contributor

sebsoto commented Aug 29, 2025

/override ci/prow/aws-e2e-operator ci/prow/azure-e2e-upgrade

@sebsoto
Copy link
Contributor

sebsoto commented Aug 29, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

@sebsoto: Overrode contexts on behalf of sebsoto: ci/prow/aws-e2e-operator, ci/prow/azure-e2e-upgrade

In response to this:

/override ci/prow/aws-e2e-operator ci/prow/azure-e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/aws-e2e-operator f8d30c2 link unknown /test aws-e2e-operator
ci/prow/azure-e2e-upgrade f8d30c2 link unknown /test azure-e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 530c07d into openshift:release-4.19 Aug 29, 2025
18 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 29, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-60967: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60967 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #3202

/assign sebsoto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sebsoto
Copy link
Contributor

sebsoto commented Sep 30, 2025

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Sep 30, 2025

@sebsoto: new pull request created: #3377

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

@rrasouli rrasouli Awaiting requested review from rrasouli

Assignees

@sebsoto sebsoto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @openshift-ci-robot @sebsoto