-
Notifications
You must be signed in to change notification settings - Fork 74
Update OCP documentation links to latest versions #3517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,7 @@ not yet supported for Windows. Instead, a Windows node can be accessed using SSH | |
| [SSH bastion](https://github.com/eparis/ssh-bastion) needs to be setup for both methods. The following information is | ||
| common across both methods: | ||
| * The key used in the *cloud-private-key* [secret](../README.md#Usage) and the key used when creating the cluster should | ||
| be added to the [ssh-agent](https://docs.redhat.com/en/documentation/openshift_container_platform/4.15/html/installing_on_azure/installing-azure-default#ssh-agent-using_installing-azure-default). | ||
| be added to the [ssh-agent](https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/installing_on_azure/installing-azure-default#ssh-agent-using_installing-azure-default). | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we use this link instead? Is this the same module in 4.20 as the 4.15?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mburke5678 is it still safe to use the |
||
| For [security reasons](https://manpages.debian.org/buster/openssh-client/ssh.1.en.html#A) we suggest removing the keys | ||
| from the ssh-agent after use. | ||
| * *\<username\>* is *Administrator* (AWS) or *capi* (Azure) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use this link instead? Is this the same module in 4.20 as the 4.15?
https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/monitoring/configuring-user-workload-monitoring#enabling-monitoring-for-user-defined-projects-uwm_preparing-to-configure-the-monitoring-stack-uwm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my tool just looks for if the URL + version + #anchor stays the same and nothing else changes. If the actual URL + version + anchor needs a change like that I'd say it'd be a separate change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like 4.13 is that last version where that URL + #anchor stays the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend using the 4.20 equivalent
https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html-single/monitoring/index#enabling-monitoring-for-user-defined-projects-uwm_preparing-to-configure-the-monitoring-stack-uwm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! I think that might have to be a separate change though because the underlying URL + #anchor is different than the original. I can help open up a separate PR after this one merges if needed?