Add bindings fix for Mat33 element-by-element constuctor
#4241
+18
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbianco
force-pushed
the
mat33_bindings_fix
branch
from
d52ddc6 to
1598303
Compare
Member
|
Thanks @nickbianco The change log may not be necessary since the version that had the issue was never made public, but doesn't hurt. |
Member
Author
|
@aymanhab thanks for the review! There was on GitHub comment suggesting that someone building from source ran into the issue, so I figured I'd throw this in the change log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4216
Brief summary of changes
Replaced the element-by-element constructor for
Mat33inBindings/SWIGSimTK/Mat.hwith the original implementation which is parseable by SWIG.Testing I've completed
Added a unit test to
test_simbody.py.Looking for feedback on...
CHANGELOG.md (choose one)
This change is