Skip to content

Unify OpenSimScene with OpenSimGUIScene #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlbertoCasasOrtiz wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Unify OpenSimScene with OpenSimGUIScene #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72c8091
Unifying OpenSimScene and OpenSimGUIScene.
AlbertoCasasOrtiz Oct 23, 2025
bef3124
Merge branch 'dev' into unify-opensimscene
AlbertoCasasOrtiz Dec 11, 2025
44c57d2
Unified OpenSimGUIScene with OpenSimGUI. Added Preview Scene. Fixed l…
AlbertoCasasOrtiz Dec 16, 2025
a5b926c
Merge pull request #331 from opensim-org/dev
AlbertoCasasOrtiz Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function App({ signOut, user }: WithAuthenticatorProps) {
/>
<Route
path="/viewer/:urlParam?"
element={<ModelViewPage />}
element={<ModelViewPage/>}
/>
<Route
path="/log_in"
Expand Down
22 changes: 10 additions & 12 deletions src/components/Components/OpenSimGUIScene.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ const OpenSimGUIScene: React.FC<OpenSimSceneProps> = ({ currentModelPath, suppor
const [currentCamera, setCurrentCamera] = useState<PerspectiveCamera>()

let curState = useModelContext();
curState.isGuiMode = true;
const modelGroup = useLoader(OpenSimLoader, currentModelPath)

//computeNormals(modelGroup as Group);
Expand Down Expand Up @@ -129,7 +128,7 @@ const OpenSimGUIScene: React.FC<OpenSimSceneProps> = ({ currentModelPath, suppor
const cameraPers = camera as PerspectiveCamera
cameraPers.aspect = aspectRatio;
cameraPers.updateProjectionMatrix();

if (envRef.current) {
envRef.current.add(camera);
}
Expand Down Expand Up @@ -346,7 +345,6 @@ const OpenSimGUIScene: React.FC<OpenSimSceneProps> = ({ currentModelPath, suppor
setUseEffectRunning(true)
};
}, [scene, supportControls, currentModelPath, curState, sceneObjectMap])


function handleClick(event: ThreeEvent<MouseEvent>): void {
//event.stopPropagation();
Expand Down Expand Up @@ -399,8 +397,15 @@ const OpenSimGUIScene: React.FC<OpenSimSceneProps> = ({ currentModelPath, suppor
shadow-camera-top={2}
shadow-camera-bottom={-2}/>
<ambientLight name="Ambient Light" intensity={0.02} color="white"/>
<directionalLight name="Dir Light2" position={[0.02, .01, .02]} intensity={1.5} color="white" castShadow={false}/>
<OpenSimFloor />
<directionalLight name="Dir Light2" position={[0.02, .01, .02]} intensity={1.5} color="grey" castShadow={false}/>
{supportControls && <OpenSimFloor />}
{supportControls && <OpenSimSkySphere
texturePath={
curState.viewerState.userPreferences?.skyTexturePath?.trim()
? curState.viewerState.userPreferences.skyTexturePath
: undefined
}
/>}
<group name='WCS' ref={csRef} visible={curState.showGlobalFrame}>
<mesh rotation={[Math.PI / 2, 0, 0]} position={[0, 0, 0.2]}>
<cylinderGeometry args={[.005, .005, 0.4, 32]}/>
Expand All @@ -416,13 +421,6 @@ const OpenSimGUIScene: React.FC<OpenSimSceneProps> = ({ currentModelPath, suppor
</mesh>
</group>
</group>
<OpenSimSkySphere
texturePath={
curState.viewerState.userPreferences?.skyTexturePath?.trim()
? curState.viewerState.userPreferences.skyTexturePath
: undefined
}
/>
<group name='Models' ref={modelsRef}
onClick={(e)=>{ handleClick(e);}}
onPointerMissed={(e)=>{clearSelection();}}
Expand Down
Loading