Fix configuration of package data #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setuptools 61+ is configured via pyproject.toml, it defaults to include-package-data = true, rather than the historical default of false. We don't want wheels to include random files from the package directory, in particular _convert.c. Disable include-package-data. In addition, we were inadvertently relying on setuptools 69+ experimental functionality to include .pyi and py.typed files in the sdist and .pyi files in wheels. Explicitly configure this. Move py.typed package-data declaration from setup.py to pyproject.toml. Fixes: b893ba2 ("Switch to PEP 621 project metadata") Fixes: a40175e ("_convert: add type hints") Fixes: 5f49c01 ("Export type hints from openslide package") Signed-off-by: Benjamin Gilbert <[email protected]>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setuptools 61+ is configured via
pyproject.toml, it defaults toinclude-package-data = true, rather than the historical default offalse. We don't want wheels to include random files from the package directory, in particular_convert.c. Disableinclude-package-data.In addition, we were inadvertently relying on setuptools 69+ experimental functionality to include
.pyiandpy.typedfiles in the sdist and.pyifiles in wheels. Explicitly configure this.Move
py.typedpackage-datadeclaration fromsetup.pytopyproject.toml.