Factories may return NULL

Author: dragosprotung

src/Qossmic/DataTransformer/ValueObjectTransformer.php

@@ -73,7 +73,7 @@ public function transform($value)
         return $this->getPropertyValue($this->form, $value);
     }
 
-    public function reverseTransform($value): object
+    public function reverseTransform($value): ?object
     {
         try {
             return (new ViewDataInstantiator($this->form, $value))->instantiateObject();

src/Qossmic/Instantiator/ObjectInstantiator.php

@@ -31,7 +31,7 @@ public function __construct($factory)
         $this->factory = $factory;
     }
 
-    public function instantiateObject(): object
+    public function instantiateObject(): ?object
     {
         if (\is_string($this->factory)) {
             $factoryMethod = (new \ReflectionClass($this->factory))->getConstructor();

tests/Integration/FactoryTest.php

@@ -21,6 +21,21 @@
 
 class FactoryTest extends AbstractDataMapperTest
 {
+    public function testFactoryReturnsNull(): void
+    {
+        $form = $this->createForm(GrossPriceType::class, null, [
+            'factory' => function () {
+                return null;
+            },
+        ]);
+        $form->submit([
+            'amount' => '500',
+            'taxRate' => '7',
+        ]);
+
+        $this->assertNull($form->getData());
+    }
+
     public function testInitializeNonCompoundRootFormWithEmptyData(): void
     {
         $form = $this->createForm(PriceType::class, null, [