-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add parseNepaliFormat method on NepaliDate #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aj3sh
wants to merge
1
commit into
main
Choose a base branch
from
parseNepaliFormat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−18
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
export { parseFormat, parse } from './parse' | ||
export { parseFormat, simpleParse } from './parse' | ||
export { parseEnglishDateFormat } from './parseEnglishDate' | ||
export { parseNepaliFormat } from './parseNepaliFormat' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* This module provides methods for parsing Nepali Date strings (in Devanagari). | ||
*/ | ||
|
||
import { | ||
NEPALI_MONTHS_EN, | ||
NEPALI_MONTHS_NE, | ||
NUM_NE, | ||
WEEKDAYS_LONG_EN, | ||
WEEKDAYS_LONG_NE, | ||
WEEKDAYS_SHORT_EN, | ||
WEEKDAYS_SHORT_NE, | ||
} from '../constants' | ||
import { parseFormat } from './parse' | ||
|
||
function convertNepaliStringToEnglish(dateStringNe: string): string { | ||
const regexLookup: Record<string, string> = { | ||
एम: 'AM', | ||
पिम: 'PM', | ||
} | ||
NEPALI_MONTHS_NE.forEach((ne, i) => (regexLookup[ne] = NEPALI_MONTHS_EN[i])) | ||
WEEKDAYS_LONG_NE.forEach((ne, i) => (regexLookup[ne] = WEEKDAYS_LONG_EN[i])) | ||
WEEKDAYS_SHORT_NE.forEach((ne, i) => (regexLookup[ne] = WEEKDAYS_SHORT_EN[i])) | ||
NUM_NE.forEach((ne, i) => (regexLookup[ne] = String(i))) | ||
|
||
// create a regex pattern | ||
const pattern = new RegExp(Object.keys(regexLookup).join('|'), 'g') | ||
|
||
// replace the match | ||
return dateStringNe.replace(pattern, match => regexLookup[match]) | ||
} | ||
|
||
export function parseNepaliFormat(dateStringNe: string, format: string): number[] { | ||
const convertedDateString = convertNepaliStringToEnglish(dateStringNe) | ||
return parseFormat(convertedDateString, format) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { parseNepaliFormat } from '../../src/parse' | ||
|
||
describe('parseNepaliFormat', () => { | ||
// another test will be covered from NepaliDate.parseNepaliFormat test | ||
it('parses the Nepali date-time string in Devanagari', () => { | ||
expect( | ||
parseNepaliFormat( | ||
'साल: २०८०, महिना: जेठ, गते(दिन): ३२, बार: बिहिबार, बार(आधा): बिहि, समय: १:३४:५६ पिम', | ||
'साल: YYYY, महिना: MMMM, गते(दिन): DD, बार: dddd, बार(आधा): ddd, समय: hh:mm:ss A' | ||
) | ||
).toEqual([2080, 1, 32, 13, 34, 56, 0]) | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.