-
Notifications
You must be signed in to change notification settings - Fork 35
feat: introduce asset caching for sqlmesh related assets #4675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
(edit: This comment is now out of date) I'm actually going to cannibalize this PR and I think I'm going to combine this and also the opensource-observer/dagster-sqlmesh#48 to provide a better solution. In opensource-observer/dagster-sqlmesh#48 we are using a solution that provides a way to Cache Assets just for the sqlmesh. Instead, I think we update the I still need to figure out exactly how I can get that to work. |
94f0b32 to
8983f4e
Compare
This currently required opensource-observer/oso-dagster# and that should be reviewed post-hoc.
We now create a new way to create cacheable dagster asset factories. Originally, I wanted a much cleaner interface but because of the way that dagster does things, it's not really possible to provide an interface that is nearly identical to dagster's interface. So we must do things in two steps minimally. The doc explains it (and needs a little bit of work) but essentially you need to do whatever operation is necessary to generate some kind cacheable intermediary asset. Then you need to provide a
rehydratorfunction that rehydrates the intermediary asset into an actual dagster asset, job, sensor, check, etc.Other things in this:
oso_corethat can cache and load any pydantic BaseModelThings I'm choosing to do later:
oso_dagster.factories.*package. It's got quite a few things that are not needed and the module organization has gotten out of hand.This PR closes the following:
TODO:
uv run oso_dagster buildto build the cache for the sqlmesh assets