chore: re-enable turbo cache by pulling plasmic version info #6007
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,4 +39,5 @@ next-env.d.ts | |
| storybook-static | ||
|
|
||
| # build files for pyodide packaging | ||
| /.pyodide | ||
| .plasmic-latest-info.txt | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "platform": "nextjs", | ||
| "code": { | ||
| "lang": "ts", | ||
| "scheme": "blackbox", | ||
| "reactRuntime": "classic" | ||
| }, | ||
| "style": { | ||
| "scheme": "css-modules", | ||
| "defaultStyleCssFilePath": "" | ||
| }, | ||
| "images": { | ||
| "scheme": "public-files", | ||
| "publicDir": "../public", | ||
| "publicUrlPrefix": "/" | ||
| }, | ||
| "tokens": { | ||
| "scheme": "theo", | ||
| "tokensFilePath": "plasmic-tokens.theo.json" | ||
| }, | ||
| "srcDir": "components", | ||
| "defaultPlasmicDir": "./plasmic", | ||
| "projects": [], | ||
| "globalVariants": { | ||
| "variantGroups": [] | ||
| }, | ||
| "wrapPagesWithGlobalContexts": true, | ||
| "nextjsConfig": { | ||
|
Member
There was a problem hiding this comment. FWIW, I think this plasmic.json isn't configured correctly (e.g. we use app router, not pages router).
Member
Author
There was a problem hiding this comment. oh ya this was intentionally the autogenerated plasmic.json since i assumed it wasn't needed with the way we use plasmic. |
||
| "pagesDir": "../pages" | ||
| }, | ||
| "cliVersion": "0.1.340", | ||
| "$schema": "https://unpkg.com/@plasmicapp/[email protected]/dist/plasmic.schema.json" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,12 +19,16 @@ | |
| "cache": false | ||
| }, | ||
| "test": {}, | ||
| "@opensource-observer/frontend#plasmic:info": { | ||
| "outputs": [".plasmic-latest-info.txt"], | ||
| "env": ["PLASMIC_PROJECT_ID", "PLASMIC_PROJECT_API_TOKEN"], | ||
|
Member
Author
There was a problem hiding this comment. I should remove the
Member
There was a problem hiding this comment. BTW, you can authenticate via environment variables with the CLI @IcaroG I'm kinda forgetting now how Plasmic CLI handles the read token so that CI doesn't need to log in? Do you recall how GitHub actions authenticates for something like this? |
||
| "cache": false | ||
| }, | ||
| "@opensource-observer/frontend#build": { | ||
| "dependsOn": ["^build", "@opensource-observer/frontend#plasmic:info"], | ||
| "outputs": ["out/**", ".next/**", "!.next/cache/**", ".pyodide/**"], | ||
| "env": ["PLASMIC_PROJECT_ID", "PLASMIC_PROJECT_API_TOKEN"] | ||
| }, | ||
| "@opensource-observer/frontend#deploy": { | ||
| "dependsOn": ["^build"], | ||
| "outputs": ["out/**", ".next/**", "!.next/cache/**", ".pyodide/**"], | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IcaroG is there a plasmic loader native way to get the current version number so that we can cache properly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞 hope there is cause this was a nasty hack