build status STARTED causes error#93
Open
riffraff wants to merge 2 commits intoopensourcehacker:masterfrom
Open
build status STARTED causes error#93riffraff wants to merge 2 commits intoopensourcehacker:masterfrom
riffraff wants to merge 2 commits intoopensourcehacker:masterfrom
Conversation
there are 2 bugs, one is that phase == 'STARTED' should plausibly be handled the same way as phase == 'STARTED', the other is that line #199 causes a KeyError when that happens, and should probably be using dict.get as line 196 does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there are 2 bugs, one is that phase == 'STARTED' should plausibly be handled the same way as phase == 'STARTED', the other is that line #199 causes a KeyError when that happens, and should probably be using dict.get as line 196 does