Skip to content

Create slightly larger body text style for android-style extension#3768

Merged
Rkareko merged 2 commits intomainfrom
3767-body-style-plus-2
Aug 13, 2025
Merged

Create slightly larger body text style for android-style extension#3768
Rkareko merged 2 commits intomainfrom
3767-body-style-plus-2

Conversation

@FikriMilano
Copy link
Copy Markdown
Member

@FikriMilano FikriMilano commented Aug 13, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3767

    {
      "linkId": "2",
      "text": "Something",
      "type": "display",
      "extension": [
        {
          "url": "https://github.com/google/android-fhir/tree/master/datacapture/android-style",
          "extension": [
            {
              "url": "question_text_view",
              "valueString": "Body_Plus_2"
            }
          ]
        }
      ]
    },

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@FikriMilano FikriMilano self-assigned this Aug 13, 2025
@FikriMilano FikriMilano requested a review from Rkareko August 13, 2025 04:34
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.3%. Comparing base (b4b5028) to head (3dc81e2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3768     +/-   ##
=========================================
- Coverage     30.0%   25.3%   -4.8%     
+ Complexity     915     815    -100     
=========================================
  Files          287     297     +10     
  Lines        15409   16074    +665     
  Branches      2703    2809    +106     
=========================================
- Hits          4628    4068    -560     
- Misses       10215   11493   +1278     
+ Partials       566     513     -53     
Flag Coverage Δ
engine 60.7% <ø> (ø)
geowidget 17.9% <ø> (ø)
quest 5.0% <ø> (-6.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 64 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FikriMilano FikriMilano changed the title Add style Create slightly larger body text style for android-style extension Aug 13, 2025
@Rkareko Rkareko merged commit a727812 into main Aug 13, 2025
17 of 19 checks passed
@Rkareko Rkareko deleted the 3767-body-style-plus-2 branch August 13, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create slightly larger body text style for android-style extension

2 participants