Use accessors for ASN1_STRING values#676
Conversation
simo5
left a comment
There was a problem hiding this comment.
LGTM,
please squash the fixups and add your sign-off to the commit
|
Covscan servers are down for maintenance, will re-run the scan later, after squash and signoff are applied |
|
Unfortunately it seems coverity is having some extended maintenance issues, I can waive it off, but the DCO check is required. @bob-beck can you please ass the sign-off-by trailer to your commit ? ( |
OpenSSL is going to make ASN1_STRING opaque. The accessors in question have been around in OpenSSL for a very long time. (see openssl/openssl#29117) Signed-off-by: Bob Beck <beck@openssl.org>
ok, I think I have? |
(BTW: I've noticed in my other projects that coverity has been dead for an extended period btw, and we're exploring alternatives at the moment) |
Yes, re-running tests and will merge
Yes, we are looking for alternatives too, apparently Blackduck stopped caring completely and decided to not even communicate a prolong shutdown or service termination, great publicity ... |
|
@bob-beck sorry to add more churn, but we just merged the coverity replacement. Would you mind rebasing on main so we can get the csbuild tests running ? |
|
On Wed, Feb 11, 2026 at 10:33:10PM +0000, Simo Sorce wrote:
simo5 left a comment (openssl-projects/pkcs11-provider#676)
@bob-beck sorry to add more churn, but we just merged the coverity replacement. Would you mind rebasing on main so we can get the csbuild tests running ?
Sure, gimme a sec
…
--
Reply to this email directly or view it on GitHub:
#676 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
|
Thanks for the contribution! (and your patience with CI woes) |
OpenSSL is going to make ASN1_STRING opaque. The accessors in question have been around in OpenSSL for a very long time.
see openssl/openssl#29117
and specifically openssl/openssl#29862
Description
Checklist
Reviewer's checklist: