Conversation
3114518 to
53bb7a7
Compare
|
Report looks reasonable: https://github.com/latchset/pkcs11-provider/actions/runs/22454953774/job/65033510484?pr=697 Would be great to have HTMLs published somehow, but that might be done separately. We can also put there some automation and differential run to make sure we are not regressing in the coverage. |
|
Unfortunately there does not seem to be any easy way to expose generate files from builds in github :/ But you can archive them as build artifacts that can be downloaded as a tar.gz and displayed in a browser |
|
@Jakuje do you want to add support for uploading the coverage THML file as a tar.gz artifact in the actions cache? |
|
Probably not. I mostly wanted to be able to get this to see where we have dead code and what might need some attention (and have makefile target to be able to run it locally). Given that github does not have a good representation, I think its easier to run it locally than downloading tarballs, but if you prefer, I can add that too. One though I had would be differential scan to fail if the coverage goes down, but it would need two runs and some regexes. We can also include the tlsfuzzer as I think it has large coverage of odd mechanisms too. That should be quite easy (while slower). |
|
I actually did the upload and enabled the tlsfuzzer tests now. |
87e4cf3 to
dd5aca9
Compare
|
@Jakuje can you rebase this one? |
This was used to run softhsm in separate process, when openssl exit handlers crashed during exit. Now it was unused for some time. Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
|
Rebased |
Description
There is no such nice report like we have in gitlab, but this at least allows running
make coverageto get HTML reports to see where we have untested code.Local run shows to me ok-ish results:
and drop leftovers of p11-kit-client.
Checklist
Reviewer's checklist: