Skip to content

x509storeissuer update #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

x509storeissuer update #50

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b37e882
x509storeissuer: factor out usage printing
esyr Oct 20, 2025
c201051
s/err/error where apropriate easiest way to fix liner issues on windows
Sashan Sep 29, 2025
948ffbd
Use perflib/err.h unconditionally
esyr Sep 25, 2025
2b3b804
perflib: add vwarn/err/warn
esyr Sep 25, 2025
ec81797
x509storeissuer: use errx/warnx for error message output
esyr Oct 20, 2025
7bbc211
x509storeissuer: factor out integer parameter parsing into a separate…
esyr Oct 20, 2025
a76d93b
x509storeissuer: provide the initial infrastructure for nonce configu…
esyr Oct 20, 2025
7e32341
x509storeissuer: add ability to configure verbosity level
esyr Oct 20, 2025
6b9361a
x509storeissuer: unify funtion definition formatting
esyr Oct 20, 2025
3924835
x509storeissuer: add -T option to specify the run time
esyr Oct 20, 2025
0b3b091
x509storeissuer: support providing multiple certificate directories
esyr Oct 20, 2025
c7f19dc
x509storeissuer: reduce the rate ossl_time_now() queries
esyr Oct 21, 2025
effd1b7
x509storeissuer: count the iterations in a local variable to avoid ha…
esyr Oct 21, 2025
a4c199d
x509storeissuer: tolerate X509_STORE_CTX_get1_issuer() successes, cou…
esyr Oct 21, 2025
4f491bf
x509storeissuer: add certificates from the provided directories to th…
esyr Oct 21, 2025
fc6682d
x509storeissuer: add and option to configure X509_STORE_CTX sharing
esyr Oct 21, 2025
5724e00
x509storeissuer: report the store size before the test run if the ver…
esyr Oct 22, 2025
a5d0c9e
x509storeissuer: make the verbose reporting more elaborate
esyr Oct 22, 2025
2282242
x509storeissuer: generate some certificates and add them to the store
esyr Oct 22, 2025
c3c4152
x509storeissuer: add support for gernerated nonces
esyr Oct 22, 2025
806e3ee
x509storeissuer: add ability to add certificates to the store during …
esyr Oct 22, 2025
9147f7f
x509storeissuer: make thread_data cache-line-aligned
esyr Oct 23, 2025
4b335f7
.github/workflows/test.yml: do not build OpenSSL apps and tests
esyr Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions source/x509storeissuer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ do_x509storeissuer(size_t num)
{
X509_STORE_CTX *ctx = X509_STORE_CTX_new();
X509 *issuer = NULL;
OSSL_TIME time;
OSSL_TIME time = ossl_time_now();

if (ctx == NULL || !X509_STORE_CTX_init(ctx, store, x509_nonce, NULL)) {
warnx("Failed to initialise X509_STORE_CTX");
Expand All @@ -172,7 +172,8 @@ do_x509storeissuer(size_t num)
}
issuer = NULL;
counts[num]++;
time = ossl_time_now();
if ((count & 0x3f) == 0)
time = ossl_time_now();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep it aligned with other tests. If there is an issue, create a new ticket where we can discuss it.

} while (time.t < max_time.t);

err:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci seems to be unhappy because of this. I would try to add return; or just empty statement ;. finge cross.

Expand Down