Skip to content

Add ability to set thread affinity #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Add ability to set thread affinity #51

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d568228
s/err/error where apropriate easiest way to fix liner issues on windows
Sashan Sep 29, 2025
caed5ee
Use perflib/err.h unconditionally
esyr Sep 25, 2025
393f457
perflib/err.c: use program_invocation_name on glibc
esyr Sep 25, 2025
953a33f
perflib: add vwarn/err/warn
esyr Sep 25, 2025
e78cd6a
perflib/err.h: add WARN/WARNX/ERR/ERRX
esyr Sep 25, 2025
1b1e38c
perflib: add ability to set thread affinity
esyr Sep 25, 2025
2484c08
pkeyread: output counts array allocation error to stderr
esyr Sep 25, 2025
0d9c3c8
pkeyread: tfix
esyr Sep 25, 2025
a1b53d4
README.md: update pkeyread documentation
esyr Sep 25, 2025
30f2a1f
pkeyread: add an option to bind threads to cores
esyr Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions source/perflib/err.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* https://www.openssl.org/source/license.html
*/

#include <errno.h>
#include <stdarg.h>
#include <stdio.h>
#include <stdlib.h>
Expand Down Expand Up @@ -38,6 +39,20 @@ vwarnx(const char *fmt, va_list ap)
putc('\n', stderr);
}

void
vwarn(const char *fmt, va_list ap)
{
int saved_errno = errno;

if (get_progname() != NULL)
fprintf(stderr, "%s: ", get_progname());
vfprintf(stderr, fmt, ap);
fprintf(stderr, ": ");

errno = saved_errno;
perror(NULL);
}

void
errx(int status, const char *fmt, ...)
{
Expand All @@ -49,6 +64,17 @@ errx(int status, const char *fmt, ...)
exit(status);
}

void
err(int status, const char *fmt, ...)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why to duplicate errx function? Same for warn and warnx

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err/warn append the output of perror() to the message, while errx/warnx just print the provided string (along with the program name as a prefix).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err/warn append the output of perror() to the message, while errx/warnx just print the provided string (along with the program name as a prefix).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now; sorry for the noise

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow why we need to duplicate all this stuff for thread affinity.. This seems unrelated.

If we want this it should probably be done separately, or we should ask ourselves why we can't use the standard stuff.

{
va_list ap;

va_start(ap, fmt);
vwarn(fmt, ap);
va_end(ap);
exit(status);
}

void
warnx(const char *fmt, ...)
{
Expand All @@ -58,3 +84,13 @@ warnx(const char *fmt, ...)
vwarnx(fmt, ap);
va_end(ap);
}

void
warn(const char *fmt, ...)
{
va_list ap;

va_start(ap, fmt);
vwarn(fmt, ap);
va_end(ap);
}
5 changes: 5 additions & 0 deletions source/perflib/err.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,13 @@
extern const char *progname;

extern void vwarnx(const char *, va_list);
extern void vwarn(const char *, va_list);

extern void errx(int, const char *, ...);
extern void err(int, const char *, ...);

extern void warnx(const char *, ...);
extern void warn(const char *, ...);

# endif /* !_WIN32 */

Expand Down