cmake: add -Wall to CFLAGS #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esyr
requested changes
Nov 7, 2025
Signed-off-by: Nikola Pajkovsky <[email protected]>
jogme
approved these changes
Nov 10, 2025
Sashan
pushed a commit
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from #64)
Contributor
|
merged in via 2821964 thanks. |
esyr
added a commit
to esyr/openssl-perftools
that referenced
this pull request
Nov 11, 2025
The changes address the following compiler warnings (reported by GCC 14):
ssl_poll_perf.c: In function ‘srvapp_setup_response’:
ssl_poll_perf.c:1553:33: warning: variable ‘pesb’ set but not used [-Wunused-but-set-variable]
1553 | struct poll_event_sbstream *pesb;
| ^~~~
ssl_poll_perf.c: In function ‘clntapp_write_custreamcb’:
ssl_poll_perf.c:2389:28: warning: unused variable ‘rb’ [-Wunused-variable]
2389 | struct request_buffer *rb;
| ^~
ssl_poll_perf.c: In function ‘clntapp_update_pec’:
ssl_poll_perf.c:2469:9: warning: variable ‘e’ set but not used [-Wunused-but-set-variable]
2469 | int e;
| ^
ssl_poll_perf.c: In function ‘main’:
ssl_poll_perf.c:3138:9: warning: unused variable ‘ccount’ [-Wunused-variable]
3138 | int ccount = 0;
| ^~~~~~
ssl_poll_perf.c: At top level:
ssl_poll_perf.c:1007:1: warning: ‘stream_state_str’ defined but not used [-Wunused-function]
1007 | stream_state_str(int stream_state)
| ^~~~~~~~~~~~~~~~
ssl_poll_perf.c:954:1: warning: ‘err_str_n’ defined but not used [-Wunused-function]
954 | err_str_n(unsigned long e, char *buf, size_t buf_sz)
| ^~~~~~~~~
Complements: openssl#64
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl-perftools
that referenced
this pull request
Nov 11, 2025
The changes address the following compiler warnings (reported by GCC 14):
ssl_poll_perf.c: In function ‘srvapp_setup_response’:
ssl_poll_perf.c:1553:33: warning: variable ‘pesb’ set but not used [-Wunused-but-set-variable]
1553 | struct poll_event_sbstream *pesb;
| ^~~~
ssl_poll_perf.c: In function ‘clntapp_write_custreamcb’:
ssl_poll_perf.c:2389:28: warning: unused variable ‘rb’ [-Wunused-variable]
2389 | struct request_buffer *rb;
| ^~
ssl_poll_perf.c: In function ‘clntapp_update_pec’:
ssl_poll_perf.c:2469:9: warning: variable ‘e’ set but not used [-Wunused-but-set-variable]
2469 | int e;
| ^
ssl_poll_perf.c: In function ‘main’:
ssl_poll_perf.c:3138:9: warning: unused variable ‘ccount’ [-Wunused-variable]
3138 | int ccount = 0;
| ^~~~~~
ssl_poll_perf.c: At top level:
ssl_poll_perf.c:1007:1: warning: ‘stream_state_str’ defined but not used [-Wunused-function]
1007 | stream_state_str(int stream_state)
| ^~~~~~~~~~~~~~~~
ssl_poll_perf.c:954:1: warning: ‘err_str_n’ defined but not used [-Wunused-function]
954 | err_str_n(unsigned long e, char *buf, size_t buf_sz)
| ^~~~~~~~~
Complements: openssl#64
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl-perftools
that referenced
this pull request
Nov 11, 2025
The changes address the following compiler warnings (reported by GCC 14):
ssl_poll_perf.c: In function ‘srvapp_setup_response’:
ssl_poll_perf.c:1553:33: warning: variable ‘pesb’ set but not used [-Wunused-but-set-variable]
1553 | struct poll_event_sbstream *pesb;
| ^~~~
ssl_poll_perf.c: In function ‘clntapp_write_custreamcb’:
ssl_poll_perf.c:2389:28: warning: unused variable ‘rb’ [-Wunused-variable]
2389 | struct request_buffer *rb;
| ^~
ssl_poll_perf.c: In function ‘clntapp_update_pec’:
ssl_poll_perf.c:2469:9: warning: variable ‘e’ set but not used [-Wunused-but-set-variable]
2469 | int e;
| ^
ssl_poll_perf.c: In function ‘main’:
ssl_poll_perf.c:3138:9: warning: unused variable ‘ccount’ [-Wunused-variable]
3138 | int ccount = 0;
| ^~~~~~
ssl_poll_perf.c: At top level:
ssl_poll_perf.c:1007:1: warning: ‘stream_state_str’ defined but not used [-Wunused-function]
1007 | stream_state_str(int stream_state)
| ^~~~~~~~~~~~~~~~
ssl_poll_perf.c:954:1: warning: ‘err_str_n’ defined but not used [-Wunused-function]
954 | err_str_n(unsigned long e, char *buf, size_t buf_sz)
| ^~~~~~~~~
Complements: openssl#64
Signed-off-by: Eugene Syromiatnikov <[email protected]>
Sashan
pushed a commit
that referenced
this pull request
Nov 12, 2025
The changes address the following compiler warnings (reported by GCC 14):
ssl_poll_perf.c: In function ‘srvapp_setup_response’:
ssl_poll_perf.c:1553:33: warning: variable ‘pesb’ set but not used [-Wunused-but-set-variable]
1553 | struct poll_event_sbstream *pesb;
| ^~~~
ssl_poll_perf.c: In function ‘clntapp_write_custreamcb’:
ssl_poll_perf.c:2389:28: warning: unused variable ‘rb’ [-Wunused-variable]
2389 | struct request_buffer *rb;
| ^~
ssl_poll_perf.c: In function ‘clntapp_update_pec’:
ssl_poll_perf.c:2469:9: warning: variable ‘e’ set but not used [-Wunused-but-set-variable]
2469 | int e;
| ^
ssl_poll_perf.c: In function ‘main’:
ssl_poll_perf.c:3138:9: warning: unused variable ‘ccount’ [-Wunused-variable]
3138 | int ccount = 0;
| ^~~~~~
ssl_poll_perf.c: At top level:
ssl_poll_perf.c:1007:1: warning: ‘stream_state_str’ defined but not used [-Wunused-function]
1007 | stream_state_str(int stream_state)
| ^~~~~~~~~~~~~~~~
ssl_poll_perf.c:954:1: warning: ‘err_str_n’ defined but not used [-Wunused-function]
954 | err_str_n(unsigned long e, char *buf, size_t buf_sz)
| ^~~~~~~~~
Complements: #64
Signed-off-by: Eugene Syromiatnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.