Conversation
nhorman
approved these changes
Feb 2, 2026
npajkovsky
approved these changes
Feb 3, 2026
Sashan
approved these changes
Feb 4, 2026
Contributor
Sashan
left a comment
There was a problem hiding this comment.
looks good. the nit I'm pointing out can be ignored.
I think we should also sort out print_help() vs. usage() I would like perftools to consistently use one or the other. but this is yet another PR.
| static OSSL_TIME max_time; | ||
|
|
||
| size_t *counts = NULL; | ||
| int run_err = 0; |
Contributor
There was a problem hiding this comment.
NIT: I think counts and run_err can be also static here.
Sashan
pushed a commit
that referenced
this pull request
Feb 4, 2026
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> MergeDate: Wed Feb 4 16:11:10 2026 (Merged from #72)
Contributor
|
changes were merged in, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CLI tool
evp_kdfthat derives keys from random data with SHA-256 digest.Runs for 5 seconds and prints the average execution time per computation.
Fixes openssl/project#1839
Features
evp_shared(default): Use EVP API and allow shared data between computationsevp_isolated: Use EVP API and don't allow shared data between computationsdeprecated_shared: Use legacy API and allow shared data between computationsdeprecated_isolated: Use legacy API and don't allow shared data between computations-t)TODO: Since freeze functionality hasn't been properly added yet (see openssl/project#1834 & openssl/openssl#29433), support for freezing the context store has not been added yet.
Usage
Findings
Initial results showed that all modes take approximately the same amount of time