Merge pull request #688 from MiguelCarpio/heatEngine.override

Remove unsupported spec.heat.template.heatEngine.override field

What does this PR do?
Remove unsupported spec.heat.template.heatEngine.override field
Why do we need it?
The OpenStackControlPlane CRD schema does not support spec.heat.template.heatEngine.override at all
╰$ oc explain openstackcontrolplane.spec.heat.template.heatEngine --recursive
GROUP:      core.openstack.org
KIND:       OpenStackControlPlane
VERSION:    v1beta1

FIELD: heatEngine <Object>


DESCRIPTION:
    <empty>
FIELDS:
  customServiceConfig	<string>
  customServiceConfigSecrets	<[]string>
  defaultConfigOverwrite	<map[string]string>
  nodeSelector	<map[string]string>
  replicas	<integer>
  resources	<Object>
    claims	<[]Object>
      name	<string> -required-
      request	<string>
    limits	<map[string]Object>
    requests	<map[string]Object>
  topologyRef	<Object>
    name	<string>
    namespace	<string>

Heat Engine is a worker service (background job processor), not an API service. It doesn't expose endpoints and doesn't need LoadBalancer configuration. It does not listen for HTTP/REST requests from users; instead, it communicates via a Message Queue using RPC. Only heatAPI needs the override configuration for load balancer and endpoint annotations.

Reviewed-by: Andrew Bays <andrew.bays@gmail.com>

Author: softwarefactory-project-zuul[bot]

lib/control-plane/service-endpoints/kustomization.yaml

@@ -16,7 +16,6 @@ replacements:
           - spec.cinder.template.cinderAPI.override.service.internal.metadata.annotations
           - spec.glance.template.glanceAPIs.default.override.service.internal.metadata.annotations
           - spec.heat.template.heatAPI.override.service.internal.metadata.annotations
-          - spec.heat.template.heatEngine.override.service.internal.metadata.annotations
           - spec.keystone.template.override.service.internal.metadata.annotations
           - spec.manila.template.manilaAPI.override.service.internal.metadata.annotations
           - spec.neutron.template.override.service.internal.metadata.annotations
@@ -79,7 +78,6 @@ replacements:
           - spec.cinder.template.cinderAPI.override.service.internal.spec.type
           - spec.glance.template.glanceAPIs.default.override.service.internal.spec.type
           - spec.heat.template.heatAPI.override.service.internal.spec.type
-          - spec.heat.template.heatEngine.override.service.internal.spec.type
           - spec.keystone.template.override.service.internal.spec.type
           - spec.manila.template.manilaAPI.override.service.internal.spec.type
           - spec.neutron.template.override.service.internal.spec.type