Skip to content

Conversation

@maximsava12
Copy link

@maximsava12 maximsava12 commented Jul 30, 2025

Glance/RBD is already covered by uni-gamma, so uni-delta could be changed to test glance/S3 instead, using the S3 API provided by ceph.

Depends-On: openstack-k8s-operators/ci-framework#3169

https://issues.redhat.com/browse/OSPRH-11411

@openshift-ci openshift-ci bot requested review from leifmadsen and raukadah July 30, 2025 08:58
@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maximsava12
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

Hi @maximsava12. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@maximsava12 maximsava12 marked this pull request as draft July 31, 2025 11:17
@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch 2 times, most recently from 8a6b4f8 to f0c3407 Compare August 6, 2025 12:14
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/79fc87b45eff4ef597e8118de04286f2

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-uni04delta FAILURE in 5m 00s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 4m 27s

@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from f0c3407 to 89fdb49 Compare August 6, 2025 14:23
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1c2bebf73a784f338791c0a5c6951196

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni04delta SUCCESS in 4m 02s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 4m 45s

@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from 89fdb49 to d8d6141 Compare August 6, 2025 14:37
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a926c527be8240ee81229d7218e2a006

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni04delta SUCCESS in 3m 48s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 4m 29s

@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from d8d6141 to 3ebcd5f Compare August 6, 2025 14:45
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f50e073907014bceb14a2dd11ac8bcbe

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni04delta SUCCESS in 5m 33s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 5m 07s

@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from 3ebcd5f to 3bc123d Compare August 10, 2025 11:37
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/161cdd1d6033493eb60a127986acf0f2

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni04delta SUCCESS in 5m 02s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 4m 32s

@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from 3bc123d to f03f77c Compare August 10, 2025 14:50
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6138b28c2f944d579ddf9672f30aaf9a

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-uni04delta FAILURE in 4m 32s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 4m 32s

@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from f03f77c to e79ae20 Compare August 10, 2025 15:49
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f45bdf7e00974987ae2482464ae73c27

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-uni04delta FAILURE in 3m 40s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 3m 28s

@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch 2 times, most recently from a9645a5 to e8d6d62 Compare August 10, 2025 18:46
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fe0c63e7d2f2444d932f89057caae1f4

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni04delta SUCCESS in 5m 44s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 5m 00s

@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from e8d6d62 to 4233ffb Compare August 10, 2025 18:58
default:
replicas: 3

s3glance.conf : |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? I see you create it via ci-framework, so in theory we do not require this definition in architecture, but I might be wrong [1].

[1] openstack-k8s-operators/ci-framework#3169

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from 4233ffb to 0a67d65 Compare August 12, 2025 08:14
@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from 0a67d65 to 7cc2853 Compare September 3, 2025 10:11
@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from 7cc2853 to 6418eeb Compare October 12, 2025 14:32
@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch 2 times, most recently from 9e179f0 to 1fe77b3 Compare October 21, 2025 11:10
Glance/RBD is already covered by uni-gamma, so uni-delta jobs could be changed to
test glance/S3 instead, using the S3 API provided by ceph.

- Updated uni04delta job architecture accordingly.

https://issues.redhat.com/browse/OSPRH-11411
@maximsava12 maximsava12 force-pushed the unidelta-glance-s3-backend branch from 1fe77b3 to 63fb947 Compare October 22, 2025 09:54
@maximsava12 maximsava12 changed the title Switch uni-delta jobs to use S3 API from Ceph Switch uni-delta job to use S3 API from Ceph Oct 23, 2025
@maximsava12 maximsava12 marked this pull request as ready for review October 23, 2025 10:10
@openshift-ci openshift-ci bot requested a review from cjeanner October 23, 2025 10:10
@abays
Copy link
Contributor

abays commented Nov 3, 2025

/ok-to-test

default:
replicas: 3
customServiceConfigSecrets:
- s3glance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this new dependency, this PR depends on openstack-k8s-operators/ci-framework#3169

@fultonj fultonj self-requested a review November 3, 2025 15:34
@fultonj
Copy link
Contributor

fultonj commented Nov 4, 2025

Without this change:

[fultonj@stybba review]$ cd architecture/examples/dt/uni04delta/
[fultonj@stybba uni04delta{main}]$ 
[fultonj@stybba uni04delta{main}]$ kustomize build . | grep glance: -A 33
  glance:
    apiOverrides:
      default:
        route: {}
    template:
      customServiceConfig: |
        [DEFAULT]
        debug = True
        enabled_backends = default_backend:rbd

        [glance_store]
        default_backend = default_backend

        [default_backend]
        rbd_store_ceph_conf = /etc/ceph/ceph.conf
        store_description = "RBD backend"
        rbd_store_pool = images
        rbd_store_user = openstack
      databaseInstance: openstack
      glanceAPIs:
        default:
          apiTimeout: 600
          networkAttachments:
          - storage
          override:
            service:
              internal:
                metadata:
                  annotations:
                    metallb.universe.tf/address-pool: internalapi
                    metallb.universe.tf/allow-shared-ip: internalapi
                    metallb.universe.tf/loadBalancerIPs: 172.17.0.80
                spec:
                  type: LoadBalancer
[fultonj@stybba uni04delta{main}]$ 

With this change:

[fultonj@stybba uni04delta{unidelta-glance-s3-backend}]$ kustomize build . | grep glance: -A 33
  glance:
    apiOverrides:
      default:
        route:
          haproxy.router.openshift.io/timeout: 60s
    template:
      customServiceConfig: |
        [DEFAULT]
        debug=True
        enabled_backends = default_backend:s3
        [glance_store]
        default_backend = default_backend
        [default_backend]
        s3_store_create_bucket_on_put = True
        s3_store_bucket_url_format = "path"
      databaseInstance: openstack
      glanceAPIs:
        default:
          customServiceConfigSecrets:
          - s3glance
          networkAttachments:
          - storage
          override:
            service:
              internal:
                metadata:
                  annotations:
                    metallb.universe.tf/address-pool: internalapi
                    metallb.universe.tf/allow-shared-ip: internalapi
                    metallb.universe.tf/loadBalancerIPs: 172.17.0.80
                spec:
                  type: LoadBalancer
          replicas: 3
      preserveJobs: false
[fultonj@stybba uni04delta{unidelta-glance-s3-backend}]$ 

@fultonj
Copy link
Contributor

fultonj commented Nov 4, 2025

I don't have any objections to this change. Depends-on needs to merge first.

Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change. Let's wait for ci-framework patch to merge before merging this one.

@fultonj
Copy link
Contributor

fultonj commented Nov 10, 2025

@maximsava12 I've added the label do-not-merge/work-in-progress to this. After your ci-framework depends-on patch merges, please remove that label so we (arch team) can see it again in our weekly review.

@maximsava12
Copy link
Author

/unhold

@maximsava12
Copy link
Author

/hold cancel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants