-
Notifications
You must be signed in to change notification settings - Fork 107
Switch uni-delta job to use S3 API from Ceph #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Switch uni-delta job to use S3 API from Ceph #592
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maximsava12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @maximsava12. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8a6b4f8 to
f0c3407
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/79fc87b45eff4ef597e8118de04286f2 ✔️ noop SUCCESS in 0s |
f0c3407 to
89fdb49
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1c2bebf73a784f338791c0a5c6951196 ✔️ noop SUCCESS in 0s |
89fdb49 to
d8d6141
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a926c527be8240ee81229d7218e2a006 ✔️ noop SUCCESS in 0s |
d8d6141 to
3ebcd5f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f50e073907014bceb14a2dd11ac8bcbe ✔️ noop SUCCESS in 0s |
3ebcd5f to
3bc123d
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/161cdd1d6033493eb60a127986acf0f2 ✔️ noop SUCCESS in 0s |
3bc123d to
f03f77c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6138b28c2f944d579ddf9672f30aaf9a ✔️ noop SUCCESS in 0s |
f03f77c to
e79ae20
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f45bdf7e00974987ae2482464ae73c27 ✔️ noop SUCCESS in 0s |
a9645a5 to
e8d6d62
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fe0c63e7d2f2444d932f89057caae1f4 ✔️ noop SUCCESS in 0s |
e8d6d62 to
4233ffb
Compare
| default: | ||
| replicas: 3 | ||
|
|
||
| s3glance.conf : | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? I see you create it via ci-framework, so in theory we do not require this definition in architecture, but I might be wrong [1].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
4233ffb to
0a67d65
Compare
0a67d65 to
7cc2853
Compare
7cc2853 to
6418eeb
Compare
9e179f0 to
1fe77b3
Compare
Glance/RBD is already covered by uni-gamma, so uni-delta jobs could be changed to test glance/S3 instead, using the S3 API provided by ceph. - Updated uni04delta job architecture accordingly. https://issues.redhat.com/browse/OSPRH-11411
1fe77b3 to
63fb947
Compare
|
/ok-to-test |
| default: | ||
| replicas: 3 | ||
| customServiceConfigSecrets: | ||
| - s3glance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of this new dependency, this PR depends on openstack-k8s-operators/ci-framework#3169
|
Without this change: [fultonj@stybba review]$ cd architecture/examples/dt/uni04delta/
[fultonj@stybba uni04delta{main}]$
[fultonj@stybba uni04delta{main}]$ kustomize build . | grep glance: -A 33
glance:
apiOverrides:
default:
route: {}
template:
customServiceConfig: |
[DEFAULT]
debug = True
enabled_backends = default_backend:rbd
[glance_store]
default_backend = default_backend
[default_backend]
rbd_store_ceph_conf = /etc/ceph/ceph.conf
store_description = "RBD backend"
rbd_store_pool = images
rbd_store_user = openstack
databaseInstance: openstack
glanceAPIs:
default:
apiTimeout: 600
networkAttachments:
- storage
override:
service:
internal:
metadata:
annotations:
metallb.universe.tf/address-pool: internalapi
metallb.universe.tf/allow-shared-ip: internalapi
metallb.universe.tf/loadBalancerIPs: 172.17.0.80
spec:
type: LoadBalancer
[fultonj@stybba uni04delta{main}]$ With this change: [fultonj@stybba uni04delta{unidelta-glance-s3-backend}]$ kustomize build . | grep glance: -A 33
glance:
apiOverrides:
default:
route:
haproxy.router.openshift.io/timeout: 60s
template:
customServiceConfig: |
[DEFAULT]
debug=True
enabled_backends = default_backend:s3
[glance_store]
default_backend = default_backend
[default_backend]
s3_store_create_bucket_on_put = True
s3_store_bucket_url_format = "path"
databaseInstance: openstack
glanceAPIs:
default:
customServiceConfigSecrets:
- s3glance
networkAttachments:
- storage
override:
service:
internal:
metadata:
annotations:
metallb.universe.tf/address-pool: internalapi
metallb.universe.tf/allow-shared-ip: internalapi
metallb.universe.tf/loadBalancerIPs: 172.17.0.80
spec:
type: LoadBalancer
replicas: 3
preserveJobs: false
[fultonj@stybba uni04delta{unidelta-glance-s3-backend}]$ |
|
I don't have any objections to this change. Depends-on needs to merge first. |
fultonj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this change. Let's wait for ci-framework patch to merge before merging this one.
|
@maximsava12 I've added the label |
|
/unhold |
|
/hold cancel |
Glance/RBD is already covered by uni-gamma, so uni-delta could be changed to test glance/S3 instead, using the S3 API provided by ceph.
Depends-On: openstack-k8s-operators/ci-framework#3169
https://issues.redhat.com/browse/OSPRH-11411