-
Notifications
You must be signed in to change notification settings - Fork 109
[Draft] Enabling CloudKitty in architecture repo. #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Draft] Enabling CloudKitty in architecture repo. #676
Conversation
|
Hi @lnatapov. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/954d1df900774aaf883ef8e328a955dc ✔️ noop SUCCESS in 0s |
913bf22 to
f370e79
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/505c6cfe3a0141da808ff3c86a11025e ✔️ noop SUCCESS in 0s |
9485acc to
d6e4cb1
Compare
| - source: | ||
| kind: ConfigMap | ||
| name: service-values | ||
| fieldPath: data.telemetry.cloudKitty.enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should reference one level higher (like MetricStorage)
i.e.
| fieldPath: data.telemetry.cloudKitty.enabled | |
| fieldPath: data.telemetry.cloudkitty |
Please note the lowercase "k" for cloudkitty
d6e4cb1 to
cd8e4ea
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d5b5c17e477043f18b99e84297a65eaf ✔️ noop SUCCESS in 0s |
cd8e4ea to
0508449
Compare
elfiesmelfie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this PR contains the changes I expected based on discussion with @abays
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elfiesmelfie, lnatapov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Enabling CloudKitty in architecture repo for future use in uni jobs.