Skip to content

Conversation

@eduolivares
Copy link
Contributor

@eduolivares eduolivares commented Dec 18, 2024

With recent changes in tobiko 0.8.4, the tobiko pods will download an already customized image instead of using official ubuntu images that were customized during tobiko execution.

@github-actions github-actions bot marked this pull request as draft December 18, 2024 16:25
@github-actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

eduolivares added a commit to eduolivares/tcib that referenced this pull request Dec 18, 2024
With recent changes in tobiko 0.8.4, the tobiko pods will download an
already customized image instead of using official ubuntu images that
were customized during tobiko execution.

Depends-On: openstack-k8s-operators/ci-framework#2619
With recent changes in tobiko 0.8.4, the tobiko pods will download an
already customized image instead of using official ubuntu images that
were customized during tobiko execution.
eduolivares added a commit to eduolivares/tcib that referenced this pull request Dec 18, 2024
With recent changes in tobiko 0.8.4, the tobiko pods will download an
already customized image instead of using official ubuntu images that
were customized during tobiko execution.

Depends-On: openstack-k8s-operators/ci-framework#2619
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bb79312f0cc64618a218686f7325f079

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 37m 47s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 02s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 23m 08s
✔️ cifmw-multinode-tempest SUCCESS in 1h 49m 44s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 59s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 54s
✔️ build-push-container-cifmw-client SUCCESS in 35m 55s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 19s

@lewisdenny
Copy link

recheck

Copy link

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Please take out of draft status when you would like it to merge :)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fe85ae8 into openstack-k8s-operators:main Dec 19, 2024
6 checks passed
@eduolivares eduolivares deleted the tobiko-custom-image branch December 19, 2024 10:09
@eduolivares
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@eduolivares: #2619 failed to apply on top of branch "18.0-fr1":

Applying: Download default customized guest image
Using index info to reconstruct a base tree...
M	roles/test_operator/README.md
M	roles/test_operator/defaults/main.yml
M	roles/test_operator/vars/main.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/test_operator/vars/main.yml
CONFLICT (content): Merge conflict in roles/test_operator/vars/main.yml
Auto-merging roles/test_operator/defaults/main.yml
Auto-merging roles/test_operator/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Download default customized guest image

Details

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

eduolivares added a commit to eduolivares/tcib that referenced this pull request Dec 20, 2024
With recent changes in tobiko 0.8.4, the tobiko pods will download an
already customized image instead of using official ubuntu images that
were customized during tobiko execution.
Due to this, the guestfs-tools package is not neeeded anymore.

Depends-On: openstack-k8s-operators/ci-framework#2619
eduolivares added a commit to eduolivares/tcib that referenced this pull request Dec 20, 2024
With recent changes in tobiko 0.8.4, the tobiko pods will download an
already customized image instead of using official ubuntu images that
were customized during tobiko execution.
Due to this, the guestfs-tools package is not neeeded anymore.

Depends-On: openstack-k8s-operators/ci-framework#2619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants