Add hypervisor param to shiftstack playbook execution #2626
Conversation
|
Skipping CI for Draft Pull Request. |
eurijon
force-pushed
the
hypervisor-param
branch
from
099dfc3 to
63abc8f
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
eurijon
force-pushed
the
hypervisor-param
branch
from
63abc8f to
099dfc3
Compare
eurijon
force-pushed
the
hypervisor-param
branch
2 times, most recently
from
eaa1c3a to
b875b34
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
eurijon
force-pushed
the
hypervisor-param
branch
from
0741b67 to
099dfc3
Compare
eurijon
force-pushed
the
hypervisor-param
branch
3 times, most recently
from
7d5721e to
f03301b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d146909601c5464095bc146e4964e874 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 32s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a964b20bcbb41d8a19fcd79f024b377 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 18s |
eurijon
force-pushed
the
hypervisor-param
branch
5 times, most recently
from
1bf8556 to
cdcd1c3
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5114043cc42740c3bb98c72e8d96353c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 59s |
|
recheck |
eurijon
force-pushed
the
hypervisor-param
branch
from
34bdcd7 to
015bfab
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ea028ac29fff478697304da0accad1f3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 29s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1959cb648eac4a9e82426a3269d50e5d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 33m 36s |
eurijon
force-pushed
the
hypervisor-param
branch
from
015bfab to
734139b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4c335784df61411f8727d3e10a52bba2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 04s |
For being able to resolve shift-on-stack apps endpoints (routes) hostnames from RHOSO pods it's required to add the DNS record entry in then dnsmasq service running on the hypervisor. It needs to be done after shift-on-stack cluster is installed as the installer is creating the floating IP for the apps endpoints, and the FIP is not known in advance. For that purpose the cifmw_shiftstack_hypervisor param is passed so the playbook running on the shiftstackclient pod is able to reach the hypervisor. This commit also adds the cifmw_shiftstack_shiftstackclient_incluster_kubeconfig_dir param to the shiftstack-qa playbook execution so it's able to find the RHOSO kubeconfig location.
eurijon
force-pushed
the
hypervisor-param
branch
from
734139b to
c7c8891
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/211e81376d004d5089ea54fd697e00b0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 08s |
|
recheck |
|
/lgtm Great work! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit bdf4ec8
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr1 |
|
@eurijon: #2626 failed to apply on top of branch "18.0-fr1": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick 18.0-fr1 |
|
@eurijon: new pull request created: #2669 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This implementation is taking advantage of the work done by Jon & Itzik in: - openstack-k8s-operators/ci-framework#2645 - openstack-k8s-operators/ci-framework#2626 Thanks to above, we can trigger tasks in the hypervisor from the shiftstack-qa, which is much more easier for us in terms of maintenability and support. The new playbook is configuring squid in the hypervisor with user/password credentials tha are stored in the secret.yaml. This playbook is also creating an user inside the hypervisor where a kubeconfig with the proxy configured inside can be found. Thanks to that, other system with the proper private key can gather this kubeconfig and access the underlying OCP. Change-Id: Id2c563926345e6b36ac28fdd51f5e3fc36d5c592 Reviewed-on: https://review.gerrithub.io/c/shiftstack/shiftstack-qa/+/1207485 Tested-by: Ramón Lobillo <rlobillo@redhat.com> Tested-by: rhosqeauto <aopincar+rhosqeauto@redhat.com> Reviewed-by: Jon Uriarte <juriarte@redhat.com> Reviewed-by: Itzik Brown <itzikb@redhat.com>
https://issues.redhat.com/browse/SOSQE-2301 The env vars: - RHOSO_KUBECONFIG - SHIFTSTACK_PASS_FILE are required for the observability test [1] in openstack-test. RHOSO kubeconfig is needed in order to access RHOSO's OCP from openstack-test. The telemetry test needs to create a scrapeConfig object in RHOSO's OCP cluster. This change depends on openstack-k8s-operators/ci-framework#2626, which actually adds the rhoso_kubeconfig param to the shiftstack-qa playbook execution. SHIFTSTACK_PASS_FILE points to the shift-on-stack kubeadmin-password file so the test is able to login as kubeadmin and retrieve a token that is required in the test. [1] openshift/openstack-test#223 Change-Id: I0ba2bd762854d228d083ed3ca0a205d05eb97a26 Reviewed-on: https://review.gerrithub.io/c/shiftstack/shiftstack-qa/+/1206509 Reviewed-by: Ramón Lobillo <rlobillo@redhat.com> Tested-by: rhosqeauto <aopincar+rhosqeauto@redhat.com> Reviewed-by: Itzik Brown <itzikb@redhat.com> Reviewed-by: Itay Matza <imatza@redhat.com>
https://issues.redhat.com/browse/SOSQE-2281 For being able to resolve shift-on-stack apps endpoints (routes) hostnames from RHOSO pods it's required to add the DNS record entry in then dnsmasq service running on the hypervisor. This commit adds the tools_cifmw_dnsmasq tools role so it's easily reusable when it's needed to add DNS entries to the `/etc/cifmw-dnsmasq.d/addresses.conf` file in the cifmw-dnsmasq service running in the hypervisor. For more info about the tools_cifmw_dnsmasq role, visit the role's README file. Requires openstack-k8s-operators/ci-framework#2626 Change-Id: Iabde163a4ef03a863d35267a3f6c8d15d830e82b Reviewed-on: https://review.gerrithub.io/c/shiftstack/shiftstack-qa/+/1205660 Reviewed-by: Ramón Lobillo <rlobillo@redhat.com> Tested-by: rhosqeauto <aopincar+rhosqeauto@redhat.com> Reviewed-by: Itzik Brown <itzikb@redhat.com> Reviewed-by: Itay Matza <imatza@redhat.com>
5 participants
For being able to resolve shift-on-stack apps endpoints (routes) hostnames from RHOSO pods it's required to add the DNS record entry in then dnsmasq service running on the hypervisor.
i.e.:
It needs to be done after shift-on-stack cluster is installed as the installer is creating the floating IP for the apps endpoints, and the FIP is not known in advance.
For that purpose the
cifmw_shiftstack_hypervisorparam is passed so the playbook running on the shiftstackclient pod is able to reach the hypervisor.The PR also adds the
cifmw_shiftstack_shiftstackclient_incluster_kubeconfig_dirparam to the shiftstack-qa playbook execution so it's able to find the RHOSO kubeconfig location.This PR depends on: #2620