-
Notifications
You must be signed in to change notification settings - Fork 144
[test_operator] Sync variables of test-operator role from defaults/main.yml in README.md automatically #3327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
48da28a to
8cc7aea
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9891cc2d5b67440bba00da71a8abbdda ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 05m 57s |
|
I would say the commit message should not be "Testing my script to update the README.md file to sync variables of tesat-operator role from defaults/main.yml" but closer to the message of the merge request |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
c2a6118 to
d348727
Compare
ab766c2 to
3ab1f58
Compare
…c variables of test-operator role from defaults/main.yml This commit will ensure to have the proper auto-sync of README.md with the defaults/main.yml file and also added the post-commit file so whenever someone commits in the defaults/main.yml file the script can be auto-run Ticket: OSPRH-19423 Add edpm-ansible-molecule-edpm_kernel for being tested when molecule change After doing improvements in molecule CI job process [1][2], the edpm_kernel CI job should be working now. [1] #3421 [2] openstack-k8s-operators/edpm-ansible#1048 Signed-off-by: Daniel Pawlik <[email protected]>
3ab1f58 to
f2652e7
Compare
|
Adding label DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1649d8d2104046a1aaef47d5a95eb4f3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 57s |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kstrenkova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall README looks nice, but there are still some descriptions missing. If it's too difficult to parse the current README maybe it would help to add a file for writing parameter descriptions for users and combining description + default into a README 🤔 However, that's just a suggestion, I don't mind the current approach 👍 I just request the descriptions for all parameters.
| * `cifmw_test_operator_controller_ip`: (String) An ip address of the controller node. Default value: `ansible_default_ipv4.address` which defaults to (`""`). | ||
| * `cifmw_test_operator_controller_namespace`: (String) Namespace inside which the test-operator-controller-manager is created. Default value: `openstack-operators` | ||
| * `cifmw_test_operator_controller_priv_key_file_path`: (String) Specifies the path to the CIFMW private key file. Note: Please ensure this file is available in the environment where the ci-framework test-operator role is executed. Default value: `~/.ssh/id_cifw` | ||
| * `cifmw_test_operator_crs_path`: Default value: See defaults in [main.yml](defaults/main.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this parameter have the reference to defaults/main.yml and not just the value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I sat a limit of characters allowed for a value in a single line because of which it is referencing to defaults/main.yml. If you want I can remove the single line values pointing to defaults/main.yml
|
This PR is stale because it has been for over 15 days with no activity. |
|
This PR is stale because it has been for over 15 days with no activity. |
This commit will ensure to have the proper auto-sync of README.md with the defaults/main.yml file and also added the post-commit file so whenever someone commits in the defaults/main.yml file the script can be auto-run Ticket: OSPRH-19423 This PR openstack-k8s-operators#3327 is closed since I am not able to reopen the PR Signing off: Saurabh Agarwal <[email protected]>
This commit will ensure to have the proper auto-sync of README.md with the defaults/main.yml file and also added the post-commit file so whenever someone commits in the defaults/main.yml file the script can be auto-run Ticket: OSPRH-19423 This PR openstack-k8s-operators#3327 is closed since I am not able to reopen the PR Signed-off-by: Saurabh Agarwal <[email protected]>
This commit will ensure to have the proper auto-sync of README.md with the defaults/main.yml file and also added the post-commit file so whenever someone commits in the defaults/main.yml file the script can be auto-run Ticket: OSPRH-19423 This PR openstack-k8s-operators#3327 is closed since I am not able to reopen the PR Signed-off-by: Saurabh Agarwal <[email protected]>
[test_operator] Testing my script to update the README.md file to sync variables of test-operator role from defaults/main.yml in README.md automatically via script.
This commit will ensure to have the proper auto-sync of README.md with the defaults/main.yml file and also added the post-commit file so whenever someone commits in the defaults/main.yml file the script can be auto-run
Ticket: OSPRH-19423