Skip to content

Conversation

@sauragar
Copy link

@sauragar sauragar commented Sep 24, 2025

[test_operator] Testing my script to update the README.md file to sync variables of test-operator role from defaults/main.yml in README.md automatically via script.
This commit will ensure to have the proper auto-sync of README.md with the defaults/main.yml file and also added the post-commit file so whenever someone commits in the defaults/main.yml file the script can be auto-run

Ticket: OSPRH-19423

@sauragar sauragar requested review from a team as code owners September 24, 2025 07:37
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sauragar sauragar force-pushed the OSPRH-19423 branch 5 times, most recently from 48da28a to 8cc7aea Compare September 24, 2025 09:46
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9891cc2d5b67440bba00da71a8abbdda

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 05m 57s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 25m 03s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 35m 44s
✔️ cifmw-multinode-tempest SUCCESS in 1h 50m 49s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 46s
cifmw-pod-pre-commit FAILURE in 10m 14s
✔️ build-push-container-cifmw-client SUCCESS in 16m 46s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 23s

@tosky
Copy link
Contributor

tosky commented Sep 25, 2025

I would say the commit message should not be "Testing my script to update the README.md file to sync variables of tesat-operator role from defaults/main.yml" but closer to the message of the merge request

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3327,1a0a2090142bf5b5176447ec89e99d4f1b18fb95

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3327,e10c50d309fe591aa65e8d46e244ac53040b3699

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3327,a9b970a9f1e0b2d8fb2a839e601734499542aa89

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3327,18d7d7408745a919f342ad22a7f61fbe1eae59c7

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3327,49fca3cf0c1cdbdd656f47463ac28b2679ae572f

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3327,62b3a97ebd0321379f878aa07d66cc2a1d6b4c25

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3327,babc6fb940a056ad9aa166740960b9df3b5a6e15

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3327,c1dfe5baafaaf0103e5943cbd7bd6be2a8b62880

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3327,8d92a8bc5ab44c7331998f6cdf3dfe2536aac31e

@sauragar sauragar force-pushed the OSPRH-19423 branch 4 times, most recently from c2a6118 to d348727 Compare November 20, 2025 10:15
@sauragar sauragar changed the title Sync variables of test-operator role from defaults/main.yml in README.md automatically [test_operator] Sync variables of test-operator role from defaults/main.yml in README.md automatically Nov 20, 2025
…c variables of test-operator role from defaults/main.yml

This commit will ensure to have the proper auto-sync of README.md with the defaults/main.yml file and also added the post-commit file so whenever someone commits in the defaults/main.yml file the script can be auto-run

Ticket: OSPRH-19423

Add edpm-ansible-molecule-edpm_kernel for being tested when molecule change

After doing improvements in molecule CI job process [1][2], the edpm_kernel
CI job should be working now.

[1] #3421
[2] openstack-k8s-operators/edpm-ansible#1048

Signed-off-by: Daniel Pawlik <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1649d8d2104046a1aaef47d5a95eb4f3

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 57s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 32m 39s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 47s
✔️ cifmw-multinode-tempest SUCCESS in 2h 07m 32s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 33s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 39s
cifmw-pod-pre-commit FAILURE in 8m 08s
✔️ build-push-container-cifmw-client SUCCESS in 17m 14s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 16s

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@kstrenkova kstrenkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall README looks nice, but there are still some descriptions missing. If it's too difficult to parse the current README maybe it would help to add a file for writing parameter descriptions for users and combining description + default into a README 🤔 However, that's just a suggestion, I don't mind the current approach 👍 I just request the descriptions for all parameters.

* `cifmw_test_operator_controller_ip`: (String) An ip address of the controller node. Default value: `ansible_default_ipv4.address` which defaults to (`""`).
* `cifmw_test_operator_controller_namespace`: (String) Namespace inside which the test-operator-controller-manager is created. Default value: `openstack-operators`
* `cifmw_test_operator_controller_priv_key_file_path`: (String) Specifies the path to the CIFMW private key file. Note: Please ensure this file is available in the environment where the ci-framework test-operator role is executed. Default value: `~/.ssh/id_cifw`
* `cifmw_test_operator_crs_path`: Default value: See defaults in [main.yml](defaults/main.yml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this parameter have the reference to defaults/main.yml and not just the value?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I sat a limit of characters allowed for a value in a single line because of which it is referencing to defaults/main.yml. If you want I can remove the single line values pointing to defaults/main.yml

@github-actions
Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 11, 2025
@sauragar sauragar removed the Stale label Dec 15, 2025
@github-actions
Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 31, 2025
@github-actions github-actions bot closed this Jan 7, 2026
@sauragar sauragar removed the Stale label Jan 7, 2026
sauragar added a commit to sauragar/ci-framework that referenced this pull request Jan 7, 2026
This commit will ensure to have the proper auto-sync of README.md with the defaults/main.yml file and also added the post-commit file so whenever someone commits in the defaults/main.yml file the script can be auto-run

Ticket: OSPRH-19423

This PR openstack-k8s-operators#3327 is closed since I am not able to reopen the PR

Signing off: Saurabh Agarwal <[email protected]>
sauragar added a commit to sauragar/ci-framework that referenced this pull request Jan 7, 2026
This commit will ensure to have the proper auto-sync of README.md with the defaults/main.yml file and also added the post-commit file so whenever someone commits in the defaults/main.yml file the script can be auto-run

Ticket: OSPRH-19423

This PR openstack-k8s-operators#3327 is closed since I am not able to reopen the PR

Signed-off-by: Saurabh Agarwal <[email protected]>
sauragar added a commit to sauragar/ci-framework that referenced this pull request Jan 8, 2026
This commit will ensure to have the proper auto-sync of README.md with the defaults/main.yml file and also added the post-commit file so whenever someone commits in the defaults/main.yml file the script can be auto-run

Ticket: OSPRH-19423

This PR openstack-k8s-operators#3327 is closed since I am not able to reopen the PR

Signed-off-by: Saurabh Agarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants